Changed by slavazanko (@slavaz) on Aug 25, 2009 at 21:15 UTC (comment 1)

if it will made someone more happy - must have :)

Changed by andrew_b (@aborodin) on Aug 26, 2009 at 18:30 UTC (comment 2)

• Severity changed from no branch to on review
• Milestone changed from 4.7 to 4.7.0-pre3

Created branch 1564_mouse_wheel_menus_listbox. Parent branch: master.
[99a05b076d97ab00067f186956d83fe413698dbb]

Changed by dmartina (dhmartina@….es) on Aug 26, 2009 at 20:43 UTC (comment 3)

Great for the menus! Both horizontal and vertical rotating! :-)

History is pending, isn't it? BTW, the Alt-h History also needs some way to escape. I mean a mouse based way to get the keyboard Esc-Esc behaviour and go back to the panels. Other dialogs have a «Cancel» button but this one doesn't (see, I'm not asking for it). Maybe clicking outside the dialog?

Changed by dmartina (dhmartina@….es) on Aug 26, 2009 at 21:06 UTC (comment 4)

Hmm, some very fine tuning:

• Wheel on first line rotates main menu
• Wheel on a particular menu rotates this menu
• Wheel outside makes menu loose focus and close. If over panel, panel and selection move.

I wouldn't close menus on wheel movement, just on key clicks. I don't now if this can be distinguished easily.

About the listing panels operated with the mouse wheel, when window is at top or bottom of the list, then selection "jumps" to first/last item. It may be smoother: keep window and decrease/increase selection in single steps.

Changed by andrew_b (@aborodin) on Aug 27, 2009 at 4:31 UTC (comment 5)

• Status changed from new to accepted
• Owner set to andrew_b

Changed by andrew_b (@aborodin) on Aug 27, 2009 at 5:06 UTC (comment 3.6)

Replying to dmartina:

Maybe clicking outside the dialog?

Already done! :) #312 comment 15

Changed by andrew_b (@aborodin) on Aug 27, 2009 at 5:14 UTC (comment 4.7)

• Severity changed from on review to on rework

Replying to dmartina:

I wouldn't close menus on wheel movement, just on key clicks. I don't now if this can be distinguished easily.

I'll try fix that.

Changed by dmartina (dhmartina@….es) on Aug 27, 2009 at 7:54 UTC (comment 6.8)

Replying to andrew_b:

Already done! :) #312 comment 15

I've found it in the ini file! Why does it default to 0?

Changed by dmartina (dhmartina@….es) on Aug 27, 2009 at 8:03 UTC (comment 8.9)

Replying to dmartina:

I've found it in the ini file! Why does it default to 0?

Sorry, now I do have read the whole thread about it :) I think that it may be optional for common dialogs (with «Cancel»), but if this one doesn't have other means of mouse-closing...

I don't want to reopen the debate. For my personal use it's fair enough to have the option as is, and now I have permanently set it.

Changed by andrew_b (@aborodin) on Aug 27, 2009 at 17:28 UTC (comment 7.10)

Replying to andrew_b:

Replying to dmartina:

I wouldn't close menus on wheel movement, just on key clicks. I don't now if this can be distinguished easily.

I'll try fix that.

[cfe4310a4a758955a4bbf924392ee9b0344754bb]

Changed by andrew_b (@aborodin) on Aug 27, 2009 at 17:29 UTC (comment 11)

• Severity changed from on rework to on review

Changed by dmartina (dhmartina@….es) on Aug 27, 2009 at 22:03 UTC (comment 12)

Much better (background clapping).

Let's do some more checking about boundary conditions.

• When rolling over the right border then selection moves, but not on left, top nor bottom lines (I'm testing with konsole+KDE+Ubuntu). Is that the expected behaviour?
• With Spanish locale, the two last menus (that is "right" and "options") are pushed to the right edge of the window and it doesn't process wheel movements on the two rightmost positions (border line and margin space). In fact, if you click there menu closes! You may reproduce this under default C locale resizing the window to a smaller width.

None of them really matters but you may want to check them.

Changed by dmartina (dhmartina@….es) on Aug 27, 2009 at 22:11 UTC

• Attachment wheel_on_panel.diff (raw) added

Smooth wheel movement on file panels

Changed by dmartina (dhmartina@….es) on Aug 27, 2009 at 22:12 UTC (comment 13)

Replying to dmartina:

About the listing panels operated with the mouse wheel, when window is at top or bottom of the list, then selection "jumps" to first/last item. It may be smoother: keep window and decrease/increase selection in single steps.

I tried it and I got a patch for screen.c
Move to new ticket or just drop it?

Changed by andrew_b (@aborodin) on Aug 28, 2009 at 5:41 UTC (comment 12.14)

Replying to dmartina:

None of them really matters but you may want to check them.

OK, I'll check that.

Changed by andrew_b (@aborodin) on Aug 28, 2009 at 5:49 UTC (comment 13.15)

Replying to dmartina:

Replying to dmartina:

About the listing panels operated with the mouse wheel, when window is at top or bottom of the list, then selection "jumps" to first/last item. It may be smoother: keep window and decrease/increase selection in single steps.

I tried it and I got a patch for screen.c

Nice. :) I like the new behavior. Thanks!

Move to new ticket or just drop it?

I think, there is no reason for new ticket. I'll commit your patch to this branch a bit later, after all menu changes.

Changed by andrew_b (@aborodin) on Aug 28, 2009 at 5:49 UTC (comment 16)

• Severity changed from on review to on rework

Changed by andrew_b (@aborodin) on Aug 28, 2009 at 11:33 UTC (comment 14.17)

Replying to andrew_b:

Replying to dmartina:

None of them really matters but you may want to check them.

OK, I'll check that.

[c956ba349f6cb630335f44f5302bdf168d81ed3f]

Changed by angel_il (@ilia-maslakov) on Aug 28, 2009 at 16:15 UTC (comment 18)

this branch broke mouse wheele behaviour when mc started in putty

Changed by angel_il (@ilia-maslakov) on Aug 28, 2009 at 16:19 UTC (comment 19)

*wheel

Changed by andrew_b (@aborodin) on Sep 7, 2009 at 12:35 UTC (comment 20)

• Severity changed from on rework to on review

Most implemented or fixed mouse wheel support items:

• scroll of listboxes
• smooth panel scrolling in first and last pages
• inactive panel is not scrollable now
• horizontal rotation of main menu
• vertical rotation of dropped menu

Also

• if main menu is hidden, single left click on the first screen row calls menu in all panel type: file list, info, tree, quick view
• single mouse click outside menu area closes menu
• if menu is dropped, single middle click executes the selected menu item independently of mouse pointer location

Known problem: if main editor menu is rotated by mouse wheel, it is not refreshed if MC is run under PuTTY.

Please review.

Changed by slavazanko (@slavaz) on Sep 14, 2009 at 8:54 UTC (comment 21)

• Votes set to slavazanko

Well... behavior in putty it's a another bug. If someone have putty - new tickets with patches are welcome ;)

All work fine. Vote here.

Changed by dmartina (dhmartina@….es) on Sep 14, 2009 at 9:37 UTC (comment 22)

• Votes changed from slavazanko to slavazanko dmartina

I use putty and I was trying this. Putty behaviour is as good or as bad as it used to be...

Changed by angel_il (@ilia-maslakov) on Sep 14, 2009 at 10:50 UTC (comment 23)

• Severity changed from on review to approved
• Votes changed from slavazanko dmartina to slavazanko dmartina angel_il

Changed by andrew_b (@aborodin) on Sep 14, 2009 at 11:09 UTC (comment 24)

• Severity changed from approved to merged
• Votes changed from slavazanko dmartina angel_il to commited-master

Merged to master.

git log --pretty=oneline c66f620..1f0b05b

Changed by andrew_b (@aborodin) on Sep 14, 2009 at 11:09 UTC (comment 25)

• Resolution set to fixed
• Status changed from accepted to testing

Changed by andrew_b (@aborodin) on Sep 14, 2009 at 11:11 UTC (comment 26)

• Status changed from testing to closed

Changed by andrew_b (@aborodin) on Sep 22, 2009 at 11:57 UTC (comment 27)

• Type changed from enhancement to defect
• Severity changed from merged to no branch
• Votes commited-master deleted
• Status changed from closed to reopened
• Resolution fixed deleted
• Version changed from 4.7.0-pre1 to master

Segfault on GPM_DRAG mouse event above or below drop-down menus.

Changed by andrew_b (@aborodin) on Sep 22, 2009 at 12:12 UTC (comment 28)

• Severity changed from no branch to on review

Created 1564_menu_mouse_drag branch. Parent branch master.
[b1721e5b5efcbdc45603a87423f33b5d091e20a6]

Changed by slavazanko (@slavaz) on Sep 22, 2009 at 12:47 UTC (comment 29)

• Severity changed from on review to on rework

Bug present in anyway :)

Changed by andrew_b (@aborodin) on Sep 22, 2009 at 17:22 UTC (comment 30)

• Severity changed from on rework to on review

[eeb9495edce2ce1133807002745011518fe15bfc] (forced update)

Changed by iNode (@iNode) on Sep 23, 2009 at 4:19 UTC (comment 31)

• Votes set to iNode

Looks good.

Changed by angel_il (@ilia-maslakov) on Sep 23, 2009 at 5:32 UTC (comment 32)

• Votes changed from iNode to iNode angel_il
• Severity changed from on review to approved

Changed by andrew_b (@aborodin) on Sep 23, 2009 at 5:39 UTC (comment 33)

• Status changed from reopened to closed
• Severity changed from approved to merged
• Votes changed from iNode angel_il to commited-master
• Resolution set to fixed

Merged to master.
[95d53b0]