Changed by zaytsev (@zyv) on Oct 9, 2009 at 15:37 UTC

• Attachment 84_use_dvicat_instead_of_dvi2tty.patch (raw) added

Changed by zaytsev (@zyv) on Oct 9, 2009 at 15:37 UTC

• Attachment 85_add_djvu_files_support.patch (raw) added

Changed by zaytsev (@zyv) on Oct 9, 2009 at 15:46 UTC

• Attachment 04_add_gem_extension.patch (raw) added

Changed by zaytsev (@zyv) on Oct 9, 2009 at 15:49 UTC

• Attachment 06_use_default_pdf_viewer.patch (raw) added

Changed by zaytsev (@zyv) on Oct 9, 2009 at 15:49 UTC

• Attachment 07_use_default_images_viewer.patch (raw) added

Changed by zaytsev (@zyv) on Oct 9, 2009 at 15:50 UTC (comment 1)

06, 07 - use "see" instead of hardcoded values. For me it's good, should we use this when possible?

Changed by zaytsev (@zyv) on Oct 9, 2009 at 17:03 UTC (comment 2)

• Blocked by set to #1690

85_add_djvu_files_support.patch <-- can be discarded

Changed by zaytsev (@zyv) on Oct 9, 2009 at 17:22 UTC (comment 3)

84_use_dvicat_instead_of_dvi2tty.patch <-- uses run-mailcap (bad), needs to be updated to use kdvi and fall back to xdvi.

04_add_gem_extension.patch <-- OK.

Changed by zaytsev (@zyv) on Oct 9, 2009 at 17:24 UTC (comment 4)

06_use_default_pdf_viewer.patch <-- needs to be redone to try consequently acroread, kpdf, evince, xpdf

Changed by zaytsev (@zyv) on Oct 9, 2009 at 17:25 UTC (comment 5)

07_use_default_images_viewer.patch <-- should be rejected.

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 22:42 UTC (comment 6)

• Status changed from new to accepted
• Owner set to slavazanko

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 22:52 UTC (comment 7)

• Milestone changed from 4.7.0-pre4 to 4.7.0-pre5
• Priority changed from trivial to major
• Type changed from defect to task

looks like Debian-specific stuff:

# yum search run-mailcap
Loaded plugins: dellsysidplugin2, downloadonly, fastestmirror, presto, refresh-packagekit
Loading mirror speeds from cached hostfile
 * fedora: mirror.datacenter.by
 * rpmfusion-free: ftp.icm.edu.pl
 * rpmfusion-free-updates: ftp.icm.edu.pl
 * rpmfusion-nonfree: ftp.icm.edu.pl
 * rpmfusion-nonfree-updates: ftp.icm.edu.pl
 * updates: mirror.datacenter.by
Warning: No matches found for: run-mailcap
No Matches found

Also, I don't know about 'see' utility.

I think, Need to create into {prefix}/libexec/mc/ some own universal wrappers (like to 'run-mailcap').

Changed by slavazanko (@slavaz) on Oct 19, 2009 at 23:08 UTC (comment 8)

Related to #1721

Changed by zaytsev (@zyv) on Oct 20, 2009 at 7:07 UTC (comment 9)

Hi Slava!

Please check my comments above about every individual patch (copy):

bugs/84_use_dvicat_instead_of_dvi2tty.patch <-- to be reworked
bugs/85_add_djvu_files_support.patch <-- to be accepted from Alt
bugs/04_add_gem_extension.patch <-- to be accepted
bugs/06_use_default_pdf_viewer.patch <-- to be reworked
bugs/07_use_default_images_viewer.patch <-- to be rejected, this is
Debian specific, not a bug (recommend zgv gqview?!)

Concerning your wrapper idea:

run-mailcap is a Perl script only available on Debian and Gentoo which essentially looks for the mime-type of the requested file and launches it using the association in system's mailcap database. I think it's the best way to do it, instead of making lots of wrappers that enumerate every single possible program on user's machine and try them one by one.

What do you think about literally integrating run-mailcap in mc? Sounds better than just reinventing the wheel. You can have a look at run-mailcap here:

http://packages.debian.org/unstable/net/mime-support

Better ideas are welcome.

Changed by zaytsev (@zyv) on Oct 20, 2009 at 7:08 UTC (comment 10)

• Blocked by changed from #1690 to #1690, #1721

Changed by slavazanko (@slavaz) on Oct 20, 2009 at 7:42 UTC

• Blocked by changed from #1690, #1721 to #1721

(In #1690) merge [a1a2164]

Changed by slavazanko (@slavaz) on Oct 27, 2009 at 20:43 UTC (comment 12)

• Milestone changed from 4.7.0 to 4.7

Changed by slavazanko (@slavaz) on Oct 31, 2011 at 20:01 UTC (comment 13)

• Milestone changed from 4.7 to Future Releases
• Branch state set to no branch
• Owner slavazanko deleted
• Status changed from accepted to assigned

Changed by slavazanko (@slavaz) on Mar 7, 2012 at 0:31 UTC (comment 14)

• Blocked by changed from #1721 to #1721, #2118

Changed by andrew_b (@aborodin) on Apr 2, 2012 at 12:32 UTC

• Blocked by changed from #1721, #2118 to #1721, #2118, #2767

Changed by andrew_b (@aborodin) on Apr 2, 2012 at 12:32 UTC

• Blocked by changed from #1721, #2118, #2767 to #2118, #2767

(In #1721) See #2767.

Changed by slavazanko (@slavaz) on May 18, 2012 at 12:07 UTC

• Blocked by changed from #2118, #2767 to #2767

(In #2118) merged to master:

git log --pretty=oneline e944301..5c6ae10

Changed by slavazanko (@slavaz) on May 21, 2012 at 7:08 UTC (comment 18)

• Owner set to slavazanko
• Status changed from assigned to accepted

Changed by andrew_b (@aborodin) on Jun 26, 2012 at 17:26 UTC (comment 19)

• Milestone changed from Future Releases to 4.8.4

Changed by andrew_b (@aborodin) on Jul 18, 2012 at 16:58 UTC (comment 20)

• Milestone changed from 4.8.4 to 4.8.5

Changed by andrew_b (@aborodin) on Sep 22, 2012 at 9:43 UTC

• Blocked by changed from #2767 to #2767, #2897

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:28 UTC

• Blocked by changed from #2767, #2897 to #2767

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:39 UTC

• Blocked by #2767 deleted

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:45 UTC (comment 24)

• Component changed from mc-vfs to mc-core
• Branch state changed from no branch to merged
• Votes set to committed-master
• Resolution set to fixed
• Milestone changed from 4.8.5 to 4.8.7
• Status changed from accepted to testing

Applied as part of #2897: [1aa122b], [804ccfb] and [5082d01].

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:45 UTC (comment 25)

• Status changed from testing to closed