Changed by s01ja (s01ja@….de) on Dec 21, 2009 at 23:58 UTC (comment 1)

• Summary changed from git autogen.sh requires cvs to update on configure

fix: install cvs

comment the autopoint files does NOT work

Changed by s01ja (s01ja@….de) on Dec 21, 2009 at 23:58 UTC (comment 2)

• Summary changed from update on configure to git autogen.sh requires cvs

Changed by andrew_b (@aborodin) on Dec 22, 2009 at 5:35 UTC

Replying to s01ja (#1885):

fix: comment
l39
l40
in ./autogen.sh

Actually, there are 92 lines only in autogen.sh.

Changed by slavazanko (@slavaz) on Dec 22, 2009 at 8:41 UTC (comment 4)

• Status changed from new to closed
• Resolution set to invalid

cvs needs just for autopoint utility. This stuff was got from gettext (version 0.17 and newer). For older versions of gettext we put into 'maint' subdir original (and unchanged) autopoint script from 'gettext' package.

If you have newest version of gettext, then own maint/autopoint will not running - will used autopoint from your gettext installation. Therefore CVS requipment it's not a mc bug.

Changed by s01ja (s01ja@….de) on Jan 31, 2010 at 1:40 UTC

• Attachment mc-git-autopoint.patch (raw) added

patch allowing testing without cvs installed

Changed by s01ja (s01ja@….de) on Jan 31, 2010 at 1:40 UTC (comment 5)

• Resolution invalid deleted
• Status changed from closed to reopened

cannot help it: every time i setup a git snapshot i am forced to install two tools: git and cvs.
just to compile and see if a bug is worth to report :(
my hosts are slow eg to save energy.
the thing i noticed in 4.6 is fixed in the current version. (good job) so i used the time compiling cvs and mc to fix the entry point for future mc developers:

with the attached patch it is now possible to do
$ git clone git://midnight-commander.org/git/mc.git
## apply patch
$ patch -p0 < mc-git-autopoint.patch
$ cd mc
$ ./autogen.sh
$ ./configure
$ make
$ ./src/mc
on a clean csv free modern system

(should be noted in the readme/install somehow)

it would be VERY nice the next time i try the git the patch is not necessary anymore.

the somewhat verbose output should warn the translating developers and when csv is installed everything works as it did before

paludis --remove cvs

host: gentoo netbook

Changed by zaytsev (@zyv) on Apr 16, 2010 at 14:49 UTC (comment 6)

• Cc set to zaytsev

Hi Slava! It seems that you are bulshitting us :) In my case cvs is required although I have latest gettext installed. It takes the version from maint anyway.

Changed by zaytsev (@zyv) on Jun 24, 2010 at 22:12 UTC (comment 7)

Can we update our gettext stuff in general? Or drop it altogether? Pros, cons?

Changed by slavazanko (@slavaz) on Nov 25, 2010 at 9:29 UTC

• Blocked by set to #2409

Changed by slavazanko (@slavaz) on Nov 26, 2010 at 9:46 UTC (comment 9)

• Status changed from reopened to accepted
• Owner set to slavazanko

Changed by slavazanko (@slavaz) on Nov 26, 2010 at 9:55 UTC (comment 10)

• Milestone changed from 4.7 to 4.7.5
• Severity changed from no branch to on review
• Blocked by #2409 deleted

Created branch 1885_autopoint_without_cvs
Initial [fc99cac]

Review, please.

Changed by slavazanko (@slavaz) on Nov 26, 2010 at 9:56 UTC (comment 11)

• Votes set to slavazanko

Changed by slavazanko (@slavaz) on Nov 26, 2010 at 10:11 UTC (comment 12)

• Votes slavazanko deleted

Sorry, have troubles in branch

Changed by slavazanko (@slavaz) on Dec 1, 2010 at 20:10 UTC (comment 13)

• Severity changed from on review to on rework

Changed by slavazanko (@slavaz) on Dec 2, 2010 at 7:34 UTC

• Blocking set to #2409

Changed by slavazanko (@slavaz) on Dec 8, 2010 at 9:47 UTC

• Blocking #2409 deleted

Changed by andrew_b (@aborodin) on Nov 6, 2011 at 7:30 UTC (comment 16)

• Milestone changed from 4.7.5 to Future Releases
• Branch state set to no branch

Changed by andrew_b (@aborodin) on Mar 16, 2016 at 7:05 UTC (comment 17)

I think this bug is not actual since gettext-0.18.1, which was released in June 2010:
http://git.savannah.gnu.org/cgit/gettext.git/tree/NEWS#n319

The configure option --with-cvs is deprecated. The 'autopoint' program will
now use the 'git' program by default to compress its archive. If the
configure option --without-git is specified, 'autopoint' will not rely on
'git', but will instead rely on a locally installed a 3 MB large archive.

But mc required gettext >= 0.14.3. I think we can update this requirement up to 0.18.1.

Changed by zaytsev-work (@zyv) on Mar 16, 2016 at 8:21 UTC (comment 18)

• Milestone changed from Future Releases to 4.8.17

I've built the 4.8.16 release tarballs with gettext-0.19.7, therefore a newer autopoint is already used. I agree that we should bump minimally required gettext version to gettext-0.18.1 and delete the autopoint script from gettext-0.18.1 from maint/utils/autopoint.

Changed by andrew_b (@aborodin) on Apr 25, 2016 at 8:42 UTC (comment 19)

• Priority changed from trivial to major
• Owner changed from slavazanko to andrew_b

Branch: 1885_autopoint_without_cvs
[81db94cbadab3f1443fe5436c2dd2e9454abf713]

Review, please.

Changed by and on Apr 25, 2016 at 19:04 UTC (comment 20)

Can we go a step further and reduce autogen.sh complexity by using autoreconf these days?

Changed by and on Apr 25, 2016 at 19:05 UTC

• Attachment mc-1885-autoreconf-usage.patch (raw) added

Changed by zaytsev (@zyv) on Apr 25, 2016 at 19:39 UTC (comment 21)

Hmmmm, that's an interesting idea: instead of getting rid of autogen.sh completely, keep it, but throw away most of it and replace with autoreconf. I think this will improve the current situation, and we can think of removing the rest later if and when we get time. However, I would also throw away the test -f checks, autoreconf will take care of that wouldn't it?

Changed by egmont (@egmontkob) on Apr 27, 2016 at 10:37 UTC (comment 22)

• Votes set to egmont

gettext-0.18.1 is a tiny bit older than glib-2.26 which we already require, so sure, let's go for it if it makes life simpler.

Changed by zaytsev (@zyv) on Apr 27, 2016 at 20:23 UTC (comment 23)

• Votes changed from egmont to egmont zaytsev

I have adapted the patch by Andreas (you're a genius, man!), pushed it to this branch and Travis checks seems to pass. Andrew, what do you think about it?

Changed by andrew_b (@aborodin) on Apr 28, 2016 at 6:28 UTC (comment 23.24)

• Branch state changed from no branch to approved

Replying to zaytsev:

Andrew, what do you think about it?

Approved.

Changed by andrew_b (@aborodin) on Apr 28, 2016 at 6:30 UTC (comment 25)

• Branch state changed from approved to merged
• Status changed from accepted to testing
• Votes changed from egmont zaytsev to committed-master
• Resolution set to fixed

Merged to master:61bc352b624aa0532b4342f206747f99cab814bb

git log --pretty=oneline 23c00cf..61bc352

Changed by andrew_b (@aborodin) on Apr 28, 2016 at 6:32 UTC (comment 26)

• Status changed from testing to closed