Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect lock files check when hostname contains wide characters #1935

Closed
mc-butler opened this issue Jan 4, 2010 · 9 comments
Closed

Incorrect lock files check when hostname contains wide characters #1935

mc-butler opened this issue Jan 4, 2010 · 9 comments
Assignees
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1935
Reporter q0tw4

Function lock_extract_info in file editlock.c uses number of unicode characters as number of bytes in string. I suggest to replace str_term_width1 at lines number 125 and 138 by strlen.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 4, 2010 at 17:15 UTC (comment 1)

Why wouldn't you provide a patch?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 4, 2010 at 17:46 UTC

  • Milestone set to 4.7.1
  • Version set to master

Replying to q0tw4 (#1935):

Function lock_extract_info in file editlock.c uses number of unicode characters as number of bytes in string. I suggest to replace str_term_width1 at lines number 125 and 138 by strlen.

Yes, I agree. Also some optimization is required: no need to calculate string length twice.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 4, 2010 at 19:16 UTC (comment 3)

  • Severity changed from no branch to on review

Created 1935_edit_lock_fix branch. Parent branch is master.
[67c37f1d10aa12588953b41e2e070be5532e9cc1]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 4, 2010 at 19:17 UTC (comment 4)

  • Owner set to andrew_b
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by metux (@metux) on Jan 15, 2010 at 1:51 UTC (comment 5)

running through testfarm, voting if it passed.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 16, 2010 at 15:44 UTC (comment 6)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 26, 2010 at 7:22 UTC (comment 7)

  • Votes changed from slavazanko to slavazanko angel_il
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 26, 2010 at 10:14 UTC (comment 8)

  • Votes changed from slavazanko angel_il to commited-master
  • Severity changed from approved to merged
  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master.
[70a41e4]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 26, 2010 at 10:19 UTC (comment 9)

  • Votes changed from commited-master to commited-master commited-stable
  • Status changed from testing to closed

in stable: [822bf10]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around
Development

No branches or pull requests

2 participants