Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some cppcheck cleanups #1953

Closed
mc-butler opened this issue Jan 10, 2010 · 14 comments
Closed

some cppcheck cleanups #1953

mc-butler opened this issue Jan 10, 2010 · 14 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1953
Reporter slyfox (@trofi)
Keywords cppcheck

http://apps.sourceforge.net/trac/cppcheck/

Issuing

mc $ cppcheck -a --force .

among many reports we get interesting hits

[./vfs/ftpfs.c:682]: (possible error) Memory leak: host
[./src/util.c:1435]: (error) Resource leak: f

---

Merged as [2c42692]

$ git log 2c42692c7^..2c42692c7
@mc-butler
Copy link
Author

Changed by slyfox (@trofi) on Jan 10, 2010 at 22:00 UTC (comment 1)

  • Severity changed from no branch to on review
  • Status changed from new to accepted

Pushed as
branch:1953_cppcheck_resleaks (2 commits)
tip [fca17611e5d0c38b2898ef68828c0e380fe7ab00]

Please review.

@mc-butler
Copy link
Author

Changed by iNode (@iNode) on Jan 11, 2010 at 4:54 UTC (comment 2)

  • Votes set to iNode

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 11, 2010 at 5:21 UTC (comment 3)

  • Severity changed from on review to approved
  • Votes changed from iNode to iNode andrew_b

@mc-butler
Copy link
Author

Changed by slyfox (@trofi) on Jan 11, 2010 at 8:36 UTC (comment 4)

  • Description edited
  • Resolution set to fixed
  • Status changed from accepted to testing

@mc-butler
Copy link
Author

Changed by slyfox (@trofi) on Jan 11, 2010 at 8:37 UTC (comment 5)

  • Severity changed from approved to merged

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 11, 2010 at 9:03 UTC (comment 6)

  • Status changed from testing to closed
  • Votes changed from iNode andrew_b to commited-master commited-stable

Cherry-picked and rebased into 4.7.0-stable: [c87b4116bda53aded5d99006b454c909ed4ba581]

@mc-butler
Copy link
Author

Changed by slyfox (@trofi) on Jan 11, 2010 at 13:31 UTC (comment 7)

  • Resolution fixed deleted
  • Description edited
  • Status changed from closed to reopened

Reseted master and reapplied with fixed typo in label:
new merge tip: [2c42692]

Sorry for the shit.

@mc-butler
Copy link
Author

Changed by slyfox (@trofi) on Jan 11, 2010 at 13:32 UTC (comment 8)

  • Status changed from reopened to closed
  • Resolution set to fixed

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 11, 2010 at 13:39 UTC (comment 9)

Cherry-picked and rebased into 4.7.0-stable: [f113255]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 12, 2010 at 12:13 UTC (comment 10)

  • Votes committed-master committed-stable deleted
  • Version changed from 4.7.0.1 to master
  • Severity changed from merged to no branch
  • Milestone changed from 4.7.1 to 4.7.5
  • Status changed from closed to reopened
  • Resolution fixed deleted

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 12, 2010 at 12:15 UTC (comment 11)

[./lib/vfs/mc-vfs/fish.c:290]: (error) Resource leak: res
[./lib/vfs/mc-vfs/samba/lib/system.c:94]: (error) Invalid number of character ({) when these macros are defined: 'HAVE_SELECT;USE_POLL'.
[./lib/vfs/mc-vfs/smbfs.c:506]: (error) Memory leak: new_entry
[./lib/vfs/mc-vfs/smbfs.c:551]: (error) Memory leak: new_entry
[./lib/vfs/mc-vfs/smbfs.c:597]: (error) Memory leak: new_entry
[./lib/vfs/mc-vfs/tar.c:726]: (error) Resource leak: tard
[./src/editor/editoptions.c:141]: (error) Uninitialized variable: p
[./src/mountlist.c:830]: (error) Memory leak: entry

Any thoughts?

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 27, 2011 at 15:33 UTC (comment 12)

  • Branch state set to no branch

26/07/2011

277/277 files checked 100% done

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 27, 2011 at 15:33 UTC (comment 13)

  • Type changed from defect to task

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jul 28, 2011 at 7:48 UTC (comment 14)

  • Status changed from reopened to closed
  • Resolution set to fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Development

No branches or pull requests

1 participant