Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTPFS: strcpy() is used for overlaping strings #2018

Closed
mc-butler opened this issue Feb 11, 2010 · 5 comments
Closed

FTPFS: strcpy() is used for overlaping strings #2018

mc-butler opened this issue Feb 11, 2010 · 5 comments
Assignees
@aborodin
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2018
Reporter andrew_b (@aborodin)

There is a following code in lib/vfs/mc-vfs/ftpfs.c file:

220         /* replace first occurance of ":/" with ":" */
221         if ((p = strchr (ret, ':')) && *(p + 1) == '/')
222             strcpy (p + 1, p + 2);

But strcpy() must not be used for overlaping objects.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 11, 2010 at 10:26 UTC (comment 1)

  • Severity changed from no branch to on review
  • Description edited

Created 2018_fptfs_strcpy branch. Parent branch is master.
[1fa19b8f818dd11b5e0df5187e26d911dcb3bef7]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Feb 17, 2010 at 11:42 UTC (comment 2)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Feb 18, 2010 at 10:10 UTC (comment 3)

  • Severity changed from on review to approved
  • Votes changed from angel_il to angel_il slavazanko

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 18, 2010 at 10:16 UTC (comment 4)

  • Votes changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • Severity changed from approved to merged
  • Status changed from new to closed

Merged to master.
[68ecccb]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 18, 2010 at 10:25 UTC (comment 5)

  • Votes changed from commited-master to commited-master commited-stable

Cherry-picked to 4.7.0-stable.
[f0628b8]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.1
Development

No branches or pull requests
2 participants
@aborodin @mc-butler