id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	blockedby	blocking	branch_state	votes
2294	mcview: incorrect starting offset for 'search again'	egmont	slavazanko	"When you press F7 in mcview to repeat the previous search, it starts again from the file offset that is 3 bytes after the beginning of the current match. This introduces weird and clearly buggy symptoms. Couple of examples:

If the file contains
{{{
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
}}}
and you search for a single x character, and you keep on pressing F7, every third character gets highlighted.

If, in the same file, you search for xxxxxxxxxxxxx (many, but way fewer x characters than in the file), the matching window keeps on moving by 3 characters.

If the file contains
{{{
xyxyxyxyxyxyxyxyxyxyxyxy
}}}
and you search for xy, you get every second match.

If the file is a shell script with comments, such at this:
{{{
#!/bin/bash
# 
# copyright stuff
#
# blah
}}}
and you search for # then the ones after the empty comment lines are skipped.

Advancing by 3 bytes is totally arbitrary and leads to buggy behavior. Either you should advance by 1 byte, or advance to the end of the previous match (these would behave differently, IMHO both of them make sense).
"	defect	closed	minor	4.8.0-pre1	mcview	4.7.3	fixed					no branch	commited-master commited-stable