Changed by andrew_b (@aborodin) on Oct 22, 2010 at 12:34 UTC

Replying to gotar (#2368):

the question must be answered, either sorting should follow it's panel while swapping, or not.

I'd prefer that all panel options must follow the panel because panel options are options of panel not options of panel location.

Changed by gotar (gotar@….pl) on Oct 27, 2010 at 17:53 UTC (comment 1.2)

On the opposite - what's the point of swapping panels along with their options? Then it's position only, mostly irrevelant, while swapping contents without options gives user a possibility to quickly peek on something and get back to primary view.
So after consideration I'd prefer to swap panels locations only.

Changed by andrew_b (@aborodin) on Dec 16, 2010 at 11:44 UTC (comment 3)

• Milestone changed from 4.7 to 4.7.5
• Owner set to andrew_b
• Severity changed from no branch to on review
• Status changed from new to accepted

Created 2368_swap_panels branch.
Initial [8ffbe19a9a8ce0fcecdb5a6597fe4311e8571297]

Changed by andrew_b (@aborodin) on Dec 28, 2010 at 13:23 UTC (comment 4)

• Milestone changed from 4.7.5 to 4.8
• Severity changed from on review to on rework
• Version changed from 4.7.4 to 4.7.5

I think we should add an option to switch the mode of file listing panel swapping:

• trivial swap, the swap of panel positions. Panel content and all panel options follow for the panel.
• swap of panel content, as is at the current time (default).

Changed by andrew_b (@aborodin) on Jan 2, 2011 at 10:44 UTC (comment 5)

• Milestone changed from 4.8 to 4.8.0-pre1
• Severity changed from on rework to on review

Modified and rebased to current master.
Initial [cfe4cec24b51658d46799b91ee983d3c2ce2376d]

Changed by slavazanko (@slavaz) on Jan 5, 2011 at 12:06 UTC (comment 6)

• Keywords set to stable-candidate
• Votes set to slavazanko

Changed by angel_il (@ilia-maslakov) on Jan 8, 2011 at 13:22 UTC (comment 7)

• Severity changed from on review to approved
• Votes changed from slavazanko to slavazanko angel_il

Changed by andrew_b (@aborodin) on Jan 8, 2011 at 13:37 UTC (comment 8)

• Severity changed from approved to merged
• Status changed from accepted to testing
• Votes changed from slavazanko angel_il to committed-master
• Resolution set to fixed

Merged to master.
[338ad4a]

git log  --pretty=oneline 7285968..338ad4a

Changed by andrew_b (@aborodin) on Jan 8, 2011 at 13:43 UTC (comment 9)

• Votes changed from committed-master to committed-master committed-stable
• Status changed from testing to closed
• Keywords stable-candidate deleted

Cherry-picked to 4.6.5-stable.
Initial [fdada76]

git log --pretty=oneline 0213c31..545baef

Changed by cri (cri@….org) on Dec 6, 2021 at 13:21 UTC (comment 10)

• Branch state set to no branch

Please note that the original problem still remains: in default mode, after the swap, the sorting order indicators in the header line on top of the screen are inconsistent with the actual sorting order of files in the panels.

This is confusing for the user, as it takes a manual reload on both panels to fix the inconsistency.

Expected behaviour: swapping the panels should automatically reload panels to make their content consistent with the sorting order settings.

Changed by andrew_b (@aborodin) on Dec 6, 2021 at 18:38 UTC (comment 11)

• Branch state changed from no branch to merged

Thanks for the report.
Fixed in 4270_cleanup branch: [d07abec]