Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vfs/extfs/helpers/u7z: improve handling of missing p7zip installation #2598

Closed
mc-butler opened this issue Aug 25, 2011 · 8 comments
Closed

vfs/extfs/helpers/u7z: improve handling of missing p7zip installation #2598

mc-butler opened this issue Aug 25, 2011 · 8 comments
Assignees
@aborodin
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.0

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2598
Reporter blueyed (mc@….de)

When p7zip is not installed, opening a 7z file will result in the following strange error message:

/usr/lib/mc/extfs.d/u7z: 78: l: not found

I will attach a patch to improve this by providing a descriptive error message to the user instead.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by blueyed (mc@….de) on Aug 25, 2011 at 12:27 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 3, 2011 at 9:40 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.0
  • Owner set to andrew_b
  • Status changed from new to accepted
  • Keywords set to stable-candidate
  • Votes set to andrew_b

Thanks!
Applied with trivial modification.

Branch: 2598_u7z (parent: master).
[4271c18]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 3, 2011 at 9:50 UTC (comment 2)

  • Branch state changed from no branch to on review

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 3, 2011 at 9:50 UTC (comment 3)

  • Votes changed from andrew_b to andrew_b slavazanko
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 3, 2011 at 9:54 UTC (comment 4)

  • Resolution set to fixed
  • Status changed from accepted to testing
  • Votes changed from andrew_b slavazanko to committed-master
  • Branch state changed from approved to merged

Merged to master.
[4271c18]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 3, 2011 at 9:59 UTC (comment 5)

  • Votes changed from committed-master to committed-master committed-stable
  • Keywords stable-candidate deleted
  • Status changed from testing to closed

Cherry-picked to 4.7.5-stable.
[90e62fc]

@mc-butler
Copy link
Author

Changed by toto (info2@…-i-aarhus.dk) on May 15, 2012 at 6:26 UTC (comment 6)

Is this still working. I'm having problems getting it to work. Can i fidn documentation besides this on the issue ?
Anders.

Changed 9 months ago by blueyed

attachment 0001-u7z-Improve-handling-of-missing-p7zip-binaries.patch added
comment:1 Changed 7 months ago by andrew_b

Keywords stable - candidate added
Owner set to andrew_b
Votes for changeset set to andrew_b
Status changed from new to accepted
Milestone changed from Future Releases to 4.8.0
Thanks!
Applied with trivial modification.
Branch: 2598_u7z (parent: master).
event changeset:4271c184de4f91bcf6d9e564f61fffcaf17d4a6a
comment:2 Changed 7 months ago by slavazanko

@mc-butler
Copy link
Author

Changed by blueyed (mc@….de) on May 15, 2012 at 9:44 UTC (comment 6.7)

Replying to toto:

Is this still working. I'm having problems getting it to work. Can i fidn documentation besides this on the issue ?
Anders.

It should still be fixed.
From the 4.8.1-stable branch: https://github.com/MidnightCommander/mc/blob/4619723e8407b01f39fc106ff48b98a05cefef6e/src/vfs/extfs/helpers/u7z

What is your problem exactly?
You should make sure that you are using a version of mc which contains the fix (4.7.5 or later).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.0
Development

No branches or pull requests
2 participants
@aborodin @mc-butler