Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doesn't compile with gcc 4.6 when using --disable-nls #2639

Closed
mc-butler opened this issue Oct 22, 2011 · 6 comments
Closed

doesn't compile with gcc 4.6 when using --disable-nls #2639

mc-butler opened this issue Oct 22, 2011 · 6 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.0 Reproducible in version 4.8.0
Milestone
4.8.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2639
Reporter ossi (@ossilator)

problem:

main.c: In function 'main':
main.c:384:12: error: expected expression before ';' token
main.c:385:12: error: expected expression before ';' token

fix:

--- a/lib/global.h
+++ b/lib/global.h
@@ -79,10 +79,10 @@
 #endif
 #else /* Stubs that do something close enough.  */
-#define textdomain(String)
+#define textdomain(String) 1
 #define gettext(String) (String)
 #define ngettext(String1,String2,Num) (((Num) == 1) ? (String1) : (String2))
 #define dgettext(Domain,Message) (Message)
 #define dcgettext(Domain,Message,Type) (Message)
-#define bindtextdomain(Domain,Directory)
+#define bindtextdomain(Domain,Directory) 1
 #define _(String) (String)
 #define N_(String) (String)
@mc-butler
Copy link
Author

Changed by guido (rds1944@….com) on Oct 22, 2011 at 23:40 UTC (comment 1)

We both found the same problem. And, yes, you were first.

Somebody was a little too aggressive in "cleaning up the code for v4.8.0".

Guido

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 23, 2011 at 12:23 UTC (comment 2)

  • Version changed from master to 4.8.0
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Votes set to andrew_b
  • Milestone changed from Future Releases to 4.8.1
  • Status changed from new to accepted

Created 2639_compile_disable_nls branch (parent: master).
[1c0cc50]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Oct 23, 2011 at 13:12 UTC (comment 3)

  • Votes changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 23, 2011 at 13:24 UTC (comment 4)

  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Votes changed from andrew_b angel_il to committed-master
  • Status changed from accepted to testing

Merged to master.
[1c0cc50]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 23, 2011 at 13:24 UTC (comment 5)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Feb 21, 2025 at 7:52 UTC (comment 6)

Ticket #2642 has been marked as a duplicate of this ticket.

@mc-butler mc-butler marked this as a duplicate of #2642 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.0 Reproducible in version 4.8.0
Milestone
4.8.1
Development

No branches or pull requests
2 participants
@aborodin @mc-butler