Ticket #2733 (closed enhancement: fixed)
The file view/edit history.
| Reported by: | angel_il | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.24 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | fsefrna@…, info@… | |
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
The file view history must shows the list of files that has recently viewed or edited.
part of #280
simple_file_edit_history_list.patch Download (1.5 KB) https://www.midnight-commander.org/raw-attachment/ticket/280/simple_file_edit_history_list.patch - added by >filipsef 6 months ago.
proof-of-concept of a simple file edit history list
Attachments
Change History
comment:1 Changed 14 years ago by angel_il
- Owner set to angel_il
- Status changed from new to accepted
comment:2 Changed 14 years ago by angel_il
- Branch state changed from no branch to on review
branch: 2733_edit_view_history
please review
comment:4 follow-ups: ↓ 6 ↓ 7 Changed 14 years ago by filipsef
I've been using the function for a couple of months now and I think it's more usable if we select the file (try_to_select) instead of editing it directly (do_edit_at_line) because
- editing the selected file is just one more keypress (F4)
- user may want to do other operations with the file (e.g. view it instead of editing) or with a different file in the same directory
- it can be then used as a 'history of visited directories where a file was edited' which is useful when history of visited directories (Alt-Shift-H) gets bloated because of lots of directory changes
Anyway, the best would be if F4 ran the editor directly and Enter selected it. Also an inline search/filter similar to Ctrl-S in panel would be nice but all this would require to use something else than history_show.
I can work on it if there is a good chance that it will be accepted. Is there ?
comment:6 in reply to: ↑ 4 Changed 14 years ago by angel_il
I can work on it if there is a good chance that it will be accepted. Is there ?
are you have github account? can you fork this branch?
comment:7 in reply to: ↑ 4 Changed 14 years ago by angel_il
Replying to filipsef:
I've been using the function for a couple of months now and I think it's more usable if we select the file
I can work on it if there is a good chance that it will be accepted. Is there ?
please try new version..
enter - goto to file
f3 - open in viewer
f4 - open into editor
comment:9 Changed 14 years ago by angel_il
maybe you wish rework the parser? little more :)
parser has follow trouble - files with space in names parsed incorrect.
comment:11 Changed 10 years ago by filipsef
I've been using this feature for years and I'd like to get it in.
I'm attaching an updated patch working with the current master.
Changed 10 years ago by filipsef
- Attachment 2733-file-edit-history.patch added
updated patch working with master on 05-13-2016
comment:12 Changed 9 years ago by andrew_b
- Owner angel_il deleted
- Status changed from accepted to assigned
comment:13 Changed 6 years ago by andrew_b
- Status changed from assigned to accepted
- Owner set to andrew_b
- Branch state changed from on rework to on review
- Milestone changed from Future Releases to 4.8.24
Branch: 2733_edit_view_history
Initial changeset:73165c9338be434adaf4be02ce528a9f6d159c02
comment:15 Changed 6 years ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:16 Changed 6 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [c853a4fbf28e590531a799af7b5cf49fd25ed7b9].
git log --pretty=oneline bc91c2d1d..c853a4fbf
