Changed by angel_il (@ilia-maslakov) on Feb 13, 2012 at 18:57 UTC (comment 1)

• Owner set to angel_il
• Status changed from new to accepted

Changed by angel_il (@ilia-maslakov) on Mar 27, 2012 at 10:29 UTC (comment 2)

• Branch state changed from no branch to on review

branch: 2733_edit_view_history

please review

Changed by angel_il (@ilia-maslakov) on Mar 27, 2012 at 11:55 UTC (comment 3)

• Cc set to fsefrna@….com

Changed by filipsef (fsefrna@….com) on Mar 27, 2012 at 14:59 UTC (comment 4)

I've been using the function for a couple of months now and I think it's more usable if we select the file (try_to_select) instead of editing it directly (do_edit_at_line) because

• editing the selected file is just one more keypress (F4)
• user may want to do other operations with the file (e.g. view it instead of editing) or with a different file in the same directory
• it can be then used as a 'history of visited directories where a file was edited' which is useful when history of visited directories (Alt-Shift-H) gets bloated because of lots of directory changes

Anyway, the best would be if F4 ran the editor directly and Enter selected it. Also an inline search/filter similar to Ctrl-S in panel would be nice but all this would require to use something else than history_show.

I can work on it if there is a good chance that it will be accepted. Is there ?

Changed by angel_il (@ilia-maslakov) on Mar 27, 2012 at 16:27 UTC (comment 5)

• Milestone changed from 4.8.2 to Future Releases

Changed by angel_il (@ilia-maslakov) on Mar 28, 2012 at 6:39 UTC (comment 4.6)

I can work on it if there is a good chance that it will be accepted. Is there ?

are you have github account? can you fork this branch?

Changed by angel_il (@ilia-maslakov) on Mar 28, 2012 at 20:02 UTC (comment 4.7)

Replying to filipsef:

I've been using the function for a couple of months now and I think it's more usable if we select the file

I can work on it if there is a good chance that it will be accepted. Is there ?

please try new version..

enter - goto to file
f3 - open in viewer
f4 - open into editor

Changed by filipsef (fsefrna@….com) on Apr 4, 2012 at 10:47 UTC (comment 8)

It looks fine, thanks a lot.

Changed by angel_il (@ilia-maslakov) on Apr 4, 2012 at 11:36 UTC (comment 9)

maybe you wish rework the parser? little more :)
parser has follow trouble - files with space in names parsed incorrect.

Changed by slavazanko (@slavaz) on Jun 6, 2012 at 11:06 UTC (comment 10)

• Branch state changed from on review to on rework

Changed by filipsef (fsefrna@….com) on May 13, 2016 at 7:02 UTC (comment 11)

I've been using this feature for years and I'd like to get it in.
I'm attaching an updated patch working with the current master.

Changed by filipsef (fsefrna@….com) on May 13, 2016 at 7:05 UTC

• Attachment 2733-file-edit-history.patch (raw) added

updated patch working with master on 05-13-2016

Changed by andrew_b (@aborodin) on Nov 29, 2016 at 7:22 UTC (comment 12)

• Owner angel_il deleted
• Status changed from accepted to assigned

Changed by andrew_b (@aborodin) on Jul 28, 2019 at 6:30 UTC (comment 13)

• Milestone changed from Future Releases to 4.8.24
• Branch state changed from on rework to on review
• Status changed from assigned to accepted
• Owner set to andrew_b

Branch: 2733_edit_view_history
Initial [73165c9338be434adaf4be02ce528a9f6d159c02]

Changed by metux (@metux) on Aug 8, 2019 at 20:25 UTC (comment 14)

• Cc changed from fsefrna@….com to fsefrna@….com, info@….net

Changed by andrew_b (@aborodin) on Aug 10, 2019 at 6:40 UTC (comment 15)

• Votes set to andrew_b
• Branch state changed from on review to approved

Changed by andrew_b (@aborodin) on Aug 10, 2019 at 6:47 UTC (comment 16)

• Votes changed from andrew_b to committed-master
• Status changed from accepted to testing
• Branch state changed from approved to merged
• Resolution set to fixed

Merged to master: [c853a4f].

git log --pretty=oneline bc91c2d1d..c853a4fbf

Changed by andrew_b (@aborodin) on Aug 10, 2019 at 6:50 UTC (comment 17)

• Status changed from testing to closed