Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ftp] Show directory sizes broken #2765

Closed
mc-butler opened this issue Mar 28, 2012 · 9 comments
Closed

[ftp] Show directory sizes broken #2765

mc-butler opened this issue Mar 28, 2012 · 9 comments
Assignees
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress ver: 4.8.2 Reproducible in version 4.8.2
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2765
Reporter x905
Mentions krokous@….cz

Command "Show directory sizes" shows zero when executed on ftp

4.8.2-26-g3907f19

@mc-butler
Copy link
Author

Changed by krokous (krokous@….cz) on Apr 11, 2012 at 11:59 UTC (comment 1)

  • Keywords set to regression
  • Cc set to krokous@….cz

I found out that the "show directory sizes" shows zero when done on .tgz archive (i.e. also VFS) and I suspect the cause for that bug is the same as the cause for this bug.

Using "git bisect" to find which commit introduced this bug resulted in this:

[0aa10fd] is the first bad commit
commit [0aa10fd]
Author: Slava Zanko <slavazanko@gmail.com>
Date: Tue Sep 27 22:13:50 2011 +0300

Changed type of WPanel::cwd (char *) and WPanel::lwd (char *)

...to WPanel::cwd_vpath (vfs_path_tr *) and WPanel::lwd_vpath (vfs_path_t *).

Signed-off-by: Slava Zanko <slavazanko@gmail.com>

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 12, 2012 at 19:24 UTC (comment 2)

  • Status changed from new to accepted
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 12, 2012 at 19:28 UTC (comment 3)

  • Milestone changed from Future Releases to 4.8.3
  • Branch state changed from no branch to on review
  • Blocking set to #2695
  • Keywords changed from regression to stable-candidate

Created branch 2765_vfs_directory_sizes [72e6dfd2e28fb51e0bc27ba62ed3f9f0da393a8f]

Review, please.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 12, 2012 at 19:29 UTC (comment 4)

This ticket is relative to #2695 and should be applied to stable after merge of #2695

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 13, 2012 at 7:12 UTC (comment 5)

  • Votes set to andrew_b
  • Version changed from master to 4.8.2

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Apr 16, 2012 at 13:46 UTC (comment 6)

  • Votes changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 18, 2012 at 7:32 UTC (comment 7)

  • Votes changed from andrew_b angel_il to committed-master
  • Resolution set to fixed
  • Status changed from accepted to testing

Merged to master: [117aa67]

git log --pretty=oneline 461b3f7..117aa67

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 18, 2012 at 7:36 UTC (comment 8)

  • Blocking #2695 deleted
  • Status changed from testing to closed
  • Keywords stable-candidate deleted
  • Votes changed from committed-master to committed-master committed-stable

Also merged to stable.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 18, 2012 at 7:38 UTC (comment 9)

  • Branch state changed from approved to merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress ver: 4.8.2 Reproducible in version 4.8.2
Development

No branches or pull requests

2 participants