Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] A few innocuous and very useful updates for mc.ext #2767

Closed
mc-butler opened this issue Mar 31, 2012 · 20 comments
Closed

[PATCH] A few innocuous and very useful updates for mc.ext #2767

mc-butler opened this issue Mar 31, 2012 · 20 comments
Assignees
@slavaz
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.7

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2767
Reporter birdie (aros@….com)
  1. Add a few more audio file types for audio 
-regex/\.([wW][mM][aA])$
+regex/\.([wW][mM][aA]|[aA][pP][eE]|[aA][aA][cC]|[wW][vV]|[mM]4[aA])$
  1. Simplify WMA handling ( -> Include=audio)
  1. Change audio and video 'View' 
-sed -n '/^ID_/p'
+sed -n 's/^ID_//p'

that will hide superfluous ID_ prefix

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Mar 31, 2012 at 12:12 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 2, 2012 at 12:32 UTC (comment 1)

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 18, 2012 at 12:07 UTC

  • Blocked by #2118 deleted

(In #2118) merged to master:

git log --pretty=oneline e944301..5c6ae10

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on May 21, 2012 at 7:09 UTC (comment 3)

  • Owner set to slavazanko
  • Milestone changed from 4.8.3 to 4.8.4
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 18, 2012 at 16:57 UTC (comment 4)

  • Milestone changed from 4.8.4 to 4.8.5

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Sep 11, 2012 at 15:01 UTC (comment 5)

  • Milestone changed from 4.8.5 to 4.8.6

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Sep 11, 2012 at 15:03 UTC (comment 6)

BTW, mplayer can "view" pretty much all audio types, so it makes sense to make it a default viewer for all audio and video files.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Sep 12, 2012 at 7:03 UTC (comment 7)

it isn't a particularly *good* audio player, though - and at least a while ago, they made a point of it being a *movie* player, not a *media* player, so no change is expected.

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Sep 12, 2012 at 10:27 UTC (comment 7.8)

Replying to ossi:

it isn't a particularly *good* audio player, though - and at least a while ago, they made a point of it being a *movie* player, not a *media* player, so no change is expected.

Actually mplayer is the best audio player in Linux as it supports hundreds of options, different filters, output formats, output sinks, volume normalization, etc. No other player is as versatile as mplayer.

It has no GUI, but then there are many GUI players which use MPLayer as a backend.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Sep 12, 2012 at 18:23 UTC (comment 9)

yes: as a backend.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 22, 2012 at 9:43 UTC

  • Blocked by set to #2897

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:28 UTC

  • Blocked by #2897 deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:38 UTC (comment 12)

  • Branch state changed from no branch to merged
  • Milestone changed from 4.8.6 to 4.8.7
  • Votes set to committed-master
  • Resolution set to fixed
  • Status changed from accepted to testing

Applied as part of #2897: [5738b8d].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 10:39 UTC (comment 13)

  • Blocking #1686 deleted
  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Oct 9, 2012 at 12:08 UTC (comment 12.14)

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to andrew_b:

Applied as part of #2897: [5738b8d].

435	 	regex/i/\.(wav|snd|voc|au|smp|aiff|snd|m4a)$ 
 	435	regex/i/\.(wav|snd|voc|au|smp|aiff|snd|m4a|ape|aac|wvm4a)$

Obviously there's a typo here: "wvm4a" should be "wv" (as m4a is still present)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 12:27 UTC (comment 15)

  • Blocked by set to #2888

@mc-butler
Copy link
Author

Changed by birdie (aros@….com) on Oct 9, 2012 at 12:45 UTC (comment 15.16)

Replying to andrew_b:

There's a typo in release notes:

"Enter into symlink to commpressed patch shows empty patch 1"

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 9, 2012 at 14:28 UTC (comment 16.17)

Thanks! A lot of typos were fixed.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 22, 2012 at 6:13 UTC

  • Blocked by #2888 deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 22, 2012 at 6:14 UTC (comment 19)

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in master branch.

@mc-butler mc-butler marked this as a duplicate of #2880 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaz slavaz

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.7
Development

No branches or pull requests
2 participants
@slavaz @mc-butler