Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"compute totals" unnecessarily done for moves #3149

Closed
mc-butler opened this issue Jan 12, 2014 · 15 comments
Closed

"compute totals" unnecessarily done for moves #3149

mc-butler opened this issue Jan 12, 2014 · 15 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.21

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3149
Reporter ossi (@ossilator)
Mentions egmont (@egmontkob), mooffie (@mooffie)

mc will compute the totals for a directory move as if it was a copy. this is obviously tremendously pointless if the move can be done cleanly with a single rename() call, and an annoying waste of time if the directory has a deep substructure.

i presume this is the result of #2075.

consequently the computation should be aware of the operation it targets.
related ticket: #20
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 16, 2014 at 14:53 UTC (comment 1)

Ticket #3185 has been marked as a duplicate of this ticket.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 30, 2015 at 17:39 UTC (comment 2)

Ticket #3395 has been marked as a duplicate of this ticket.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 8, 2016 at 4:02 UTC (comment 3)

Ticket #3653 has been marked as a duplicate of this ticket.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 20, 2016 at 12:00 UTC (comment 4)

  • Owner set to andrew_b
  • Status changed from new to accepted

Branch: 3149_move_compute_total
Initial [6e86e4873a8498bc4ccfbdfeb93155eeaf18e502]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 22, 2016 at 6:24 UTC (comment 5)

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.18

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 19, 2017 at 8:31 UTC (comment 6)

  • Branch state changed from on review to on rework

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 12, 2017 at 7:47 UTC (comment 7)

  • Branch state changed from on rework to on review

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 12, 2017 at 15:48 UTC (comment 8)

Does anybody want review this branch after 4 weeks?

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 12, 2017 at 19:31 UTC (comment 9)

  • Cc set to egmont, mooffie

I'm completely overloaded @ $DAYJOB, so no chance I can get to it anytime soon :-/ Maybe egmont or mooffie? Or even the reporter?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 28, 2017 at 6:57 UTC (comment 10)

  • Branch state changed from on review to on rework

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 18, 2017 at 17:31 UTC (comment 11)

  • Milestone changed from 4.8.20 to 4.8.21

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 1, 2018 at 10:41 UTC (comment 12)

  • Branch state changed from on rework to on review

Branch: 3149_move_compute_total
Initial [6e86e4873a8498bc4ccfbdfeb93155eeaf18e502]

Please review.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 3, 2018 at 15:35 UTC (comment 13)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 3, 2018 at 15:37 UTC (comment 14)

  • Resolution set to fixed
  • Branch state changed from approved to merged
  • Votes changed from andrew_b to committed-master
  • Status changed from accepted to testing

Merged to master: [e4d9a81].

git log --pretty=oneline 1782809..e4d9a81

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 3, 2018 at 15:39 UTC (comment 15)

  • Status changed from testing to closed

@mc-butler mc-butler mentioned this issue Nov 3, 2018
Closed
@mc-butler mc-butler marked this as a duplicate of #3185 Feb 28, 2025
@mc-butler mc-butler marked this as a duplicate of #3395 Feb 28, 2025
@mc-butler mc-butler marked this as a duplicate of #3653 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.21
Development

No branches or pull requests
2 participants
@aborodin @mc-butler