Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcedit: status line no longer shows full path to file #3285

Closed
mc-butler opened this issue Oct 16, 2014 · 8 comments
Closed

mcedit: status line no longer shows full path to file #3285

mc-butler opened this issue Oct 16, 2014 · 8 comments
Assignees
@aborodin
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around ver: 4.8.13 Reproducible in version 4.8.13
Milestone
4.8.14

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3285
Reporter onlyjob (@onlyjob)

As reported in Debian

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764226

mcedit used to print the full path of the current file in the status bar.
In new version of MC (4.8.13), this is unfortunately no longer the case.
(mcview still shows the full path).

I agree with reporter that it is more convenient to see full path in mcedit and that it is nice when such behaviour is in line with mcview. Please revert.

The following (untested) patch was proposed:

--- editdraw.c.orig	2014-09-02 12:23:58.000000000 +0300
+++ editdraw.c	2014-10-08 23:05:18.000000000 +0300
@@ -210,7 +210,7 @@
     status_len = (int) str_term_width1 (status);
 
     if (edit->filename_vpath != NULL)
-        fname = x_basename (vfs_path_get_last_path_str (edit->filename_vpath));
+        fname = vfs_path_get_last_path_str (edit->filename_vpath);
 
     fname_len = str_term_width1 (fname);
     if (fname_len < preferred_fname_len)
@@ -264,7 +264,7 @@
 
         if (edit->filename_vpath != NULL)
         {
-            fname = x_basename (vfs_path_as_str (edit->filename_vpath));
+            fname = vfs_path_as_str (edit->filename_vpath);
         }
 #ifdef ENABLE_NLS
         else
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 25, 2015 at 11:06 UTC (comment 1)

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.14

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 25, 2015 at 12:25 UTC (comment 2)

  • Branch state changed from no branch to on review

Branch: 3285_mcedit_full_path.
[00d9200352fd2ff0c9be4a669544a93efc031004]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 14, 2015 at 21:20 UTC (comment 3)

  • Votes set to slavazanko
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 15, 2015 at 4:54 UTC (comment 4)

  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Votes changed from slavazanko to committed-master

Merged to master: [be38f70].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 15, 2015 at 4:55 UTC (comment 5)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by onlyjob (@onlyjob) on Nov 12, 2015 at 7:02 UTC (comment 6)

  • Resolution fixed deleted
  • Version changed from 4.8.13 to 4.8.15
  • Status changed from closed to reopened
  • Milestone changed from 4.8.14 to Future Releases

Although this regression was fixed in 4.8.14 it returned with 4.8.15. Please fix it (again). Cheers.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 12, 2015 at 7:35 UTC (comment 6.7)

  • Milestone changed from Future Releases to 4.8.14
  • Status changed from reopened to closed
  • Resolution set to fixed
  • Version changed from 4.8.15 to 4.8.13

Replying to onlyjob:

Although this regression was fixed in 4.8.14 it returned with 4.8.15. Please fix it (again). Cheers.

Look at #3445. Cheers.

@mc-butler
Copy link
Author

Changed by onlyjob (@onlyjob) on Nov 12, 2015 at 10:39 UTC (comment 8)

I see, thanks. Perhaps defaults are badly chosen as mcview shows full path while mcedit is not. It would be better to preserve classic, consistent presentation instead of flipping it back and forth over last 3 releases. Also, I'd prefer accessing this configuration option from menu.

@mc-butler mc-butler mentioned this issue Nov 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around ver: 4.8.13 Reproducible in version 4.8.13
Milestone
4.8.14
Development

No branches or pull requests
2 participants
@aborodin @mc-butler