Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isofs doesn't show .dotfiles #3537

Closed
mc-butler opened this issue Oct 15, 2015 · 12 comments
Closed

isofs doesn't show .dotfiles #3537

mc-butler opened this issue Oct 15, 2015 · 12 comments
Assignees
@zyv
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.16

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3537
Reporter vda (@dvlasenk)

There appears to be an easy bug in iso9660 helper:

if (name ~ /^\.\.?/) next

means "skip all lines which start with one or two dots".
Author probably meant: if (name ~ /^\.\.?$/) next

I propose to not be cryptic and just check both possibilities separately.

The below trivial patch was tested to work: now I see
the file named ".dot" in a test iso file.

(Note: there seems to be another bug: SEMICOLON = "YES"
is not a correct comparison (should use ==),
it's assignment! As a result, sub(";1$", "", name);
is always executed).

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by vda (@dvlasenk) on Oct 15, 2015 at 21:18 UTC

patch

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 16, 2015 at 16:55 UTC (comment 1)

  • Description edited
  • Component changed from mc-core to mc-vfs

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 18, 2015 at 18:11 UTC (comment 2)

  • Owner set to zaytsev
  • Branch state changed from no branch to on hold
  • Milestone changed from Future Releases to 4.8.15
  • Status changed from new to accepted

Branch: 3537_isofs_dotfiles.
Changeset: [e591862f219f7d8d11cacc894aa80f7b9fc18960].

Denys, could you please be so kind as to make a "SEMICOLON = "YES"" patch, so that we can close everything in one go? Thanks!

@mc-butler
Copy link
Author

Changed by vda (@dvlasenk) on Oct 23, 2015 at 10:55 UTC

SEMICOLON == "YES" fix

@mc-butler
Copy link
Author

Changed by vda (@dvlasenk) on Oct 23, 2015 at 10:57 UTC (comment 3)

The SEMICOLON == "YES" patch is technically correct, but if, say, SEMICOLON="YES" isn't set correctly somewhere (imagine another bug), the result of this patch may be that isofs would start showing files with FILE;N suffixes.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 23, 2015 at 20:19 UTC (comment 4)

Apparently introduced in #2471.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 23, 2015 at 20:22 UTC (comment 5)

May be related to #2851.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 6, 2015 at 15:49 UTC (comment 6)

  • Milestone changed from 4.8.15 to 4.8.16

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 31, 2015 at 8:08 UTC (comment 7)

  • Votes set to andrew_b
  • Branch state changed from on hold to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 31, 2015 at 8:10 UTC (comment 8)

  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged
  • Status changed from accepted to testing

Merged to master: [24d09ba].

git log --pretty=oneline 2540595..24d09ba

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 31, 2015 at 8:12 UTC (comment 9)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 1, 2016 at 9:24 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyv zyv

Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.16
Development

No branches or pull requests
2 participants
@zyv @mc-butler