Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse clicking in listbox doesn't notify dialog of change #3562

Closed
mc-butler opened this issue Nov 21, 2015 · 4 comments
Closed

Mouse clicking in listbox doesn't notify dialog of change #3562

mc-butler opened this issue Nov 21, 2015 · 4 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.16

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3562
Reporter mooffie (@mooffie)

The listbox widget has a useful feature (#313): it sends MSG_ACTION to the dialog to notify it when the selected item changes. This makes it easy to implement the common UI pattern in which widgets update themselves in response to listbox change.

This UI pattern is used in the following dialogs:

However, this MSG_ACTION isn't fired for changes caused by mouse clicking. Only for those caused by the keyboard.

This patch fixes this.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 21, 2015 at 22:19 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 22, 2015 at 13:57 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 8, 2016 at 10:34 UTC (comment 2)

  • Branch state changed from no branch to merged
  • Milestone changed from Future Releases to 4.8.16
  • Votes set to committed-master
  • Status changed from new to closed
  • Resolution set to fixed

Applied in #3569 as [aa693fb].

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:06 UTC

@mc-butler mc-butler mentioned this issue Feb 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.16
Development

No branches or pull requests
1 participant
@mc-butler