Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"External Panelize" dialog should use WListbox's change notification. #3565

Closed
mc-butler opened this issue Nov 21, 2015 · 5 comments
Closed

"External Panelize" dialog should use WListbox's change notification. #3565

mc-butler opened this issue Nov 21, 2015 · 5 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.16

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3565
Reporter mooffie (@mooffie)

Currently it uses a MSG_POST_KEY/MSG_FOCUS hack to achieve this.

Advantage:

We'll get rid of a subtle mouse bug. The use of MSG_FOCUS in the hack inadvertently makes clicking the mouse update the command. But MSG_FOCUS is actually fired before the listbox changes its item, so the command seen is the previously selected (you don't always notice this because WListbox's mouse handler uses MOU_REPEAT, which makes the problem sometime fix itself after a fraction of a second).

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 21, 2015 at 22:39 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Nov 21, 2015 at 22:54 UTC (comment 1)

Note that after tending to #3566 the code will be tidier:

case MSG_INIT: 
case MSG_NOTIFY:
    update_command ();
    return MSG_HANDLED;

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 22, 2015 at 13:57 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 8, 2016 at 10:37 UTC (comment 3)

  • Votes set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Milestone changed from Future Releases to 4.8.16
  • Status changed from new to closed

Applied in #3569 as [755a2b8].

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Feb 22, 2025 at 11:06 UTC

@mc-butler mc-butler mentioned this issue Feb 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.16
Development

No branches or pull requests
1 participant
@mc-butler