id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	blockedby	blocking	branch_state	votes
3606	[BUG] segfault on SHELL=bash	and	andrew_b	"When using non-path SHELL variable like
{{{
$ SHELL=bash /usr/bin/mc
}}}
we will hit segfault at
{{{
==18747==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7ff92915602d bp 0x7ff92a327300 sp 0x7ffdcd67b698 T0)
    #0 0x7ff92915602c  (/lib64/libc.so.6+0x9e02c)
    #1 0x44d865 in __interceptor_strstr (/usr/bin/mc+0x44d865)
    #2 0x7ff92a233dd6 in mc_shell_recognize_and_fill_type /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/shell.c:151:52
    #3 0x7ff92a233dd6 in mc_shell_init /tmp/portage/app-misc/mc-9999/work/mc-9999/lib/shell.c:233
    #4 0x4f7b92 in OS_Setup /tmp/portage/app-misc/mc-9999/work/mc-9999/src/main.c:128:5
    #5 0x4f7b92 in main /tmp/portage/app-misc/mc-9999/work/mc-9999/src/main.c:250
    #6 0x7ff9290d88fb in __libc_start_main (/lib64/libc.so.6+0x208fb)
    #7 0x427148 in _start (/usr/bin/mc+0x427148)
}}}
root cause is not checking null case when filling mc_shell->real_path variable from mc_realpath()/realpath().

"	defect	closed	major	4.8.17	mc-core	4.8.16	fixed					merged	committed-master