Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop automatic migration of configuration from ~/.mc to XDG-base #3682

Closed
mc-butler opened this issue Aug 28, 2016 · 11 comments
Closed

Drop automatic migration of configuration from ~/.mc to XDG-base #3682

mc-butler opened this issue Aug 28, 2016 · 11 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.27

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3682
Reporter andrew_b (@aborodin)
Mentions zaytsev (@zyv)

Before 4.8.1, the mc configuration was locate in ~/.mc directory. After implementation of XGD-based configuration (#1851), mc copies configuration from old directory to new XDG-based place if it doesn't exist and then uses it.

Now after 4 years we can drop this automatic migration and clean up the codebase.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 8, 2016 at 6:23 UTC

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Sep 8, 2016 at 13:08 UTC (comment 2)

Just to clarify:

There are two migration mechanisms:

  1. Moving files from ~/.mc to XDG place (done by the old_filename field in the mc_config_files_reference table).
  1. Moving certain files from one XDG place to another XDG place (done by the mc_config_migrate_rules_fix table). E.g., from ~/.cache/mc/history to ~/.local/share/mc/history. This was needed to fix mistakes we make in choosing the placement of various files.

You're talking about removing only (1), right? Because we're still going to need (2), to fix issues like #3687 (in the future we might want to relocate other files similarly).

In (2) it's probably fine to remove the current rules, though. These rules were added in Nov 2011 (commit 25c9267), less than a year after XDG support was added (Dec 2010, commit acbe048).

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Sep 8, 2016 at 17:02 UTC (comment 3)

Some food for thought:

It's possible to compile MC without XDG support. Maybe we should keep the migration code so it could be used (in the future) to migrate these users to XDG?

Feel free to discard this quick note: I haven't thought much about it.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 25, 2016 at 20:11 UTC (comment 4)

  • Cc set to zaytsev

I'd say that dropping it now is very premature: RHEL 6 is shipping mc-4.7.0.2 by default (EOL: 2020) and RHEL 5 (EOL: 2017 / 2020) is shipping mc-4.6.1a. I'm not sure what's the situation with SLES, but I bet the situation is similar. I'm not necessarily saying that we have to wait at least 4 more years, but maybe at very least until RHEL 8 comes out. There are still tons and tons of homes to be upgraded...

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 29, 2016 at 8:43 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 23, 2021 at 18:27 UTC (comment 6)

I think it's time to do that. It's 2021 now.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jan 24, 2021 at 11:28 UTC (comment 7)

Fine by me.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 7, 2021 at 13:31 UTC (comment 8)

  • Branch state changed from no branch to on review
  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.27

Branch: 3682_drop_automatic_config_migration
[0b317ea5f265596db8d4387e613aa76ff0d63007]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 22, 2021 at 18:16 UTC (comment 9)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 22, 2021 at 18:19 UTC (comment 10)

  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Status changed from accepted to testing
  • Votes changed from andrew_b to committed-master

Merged to master: [b6de6e8].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 22, 2021 at 18:21 UTC (comment 11)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.27
Development

No branches or pull requests
2 participants
@aborodin @mc-butler