id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	blockedby	blocking	branch_state	votes
3789	extfs: rpm helper misses CONFLICTS field	mooffie	zaytsev	"The rpm helper has a typo. A fix suggested by users in #3750 and #3781 is:

{{{#!diff
--- a/src/vfs/extfs/helpers/rpm
+++ b/src/vfs/extfs/helpers/rpm
@@ -89,7 +89,7 @@ mcrpmfs_getDesription()
 mcrpmfs_getAllNeededTags()
 {
     supportedTags=`mcrpmfs_getSupportedTags`
-    if test ""`echo supportedTags | grep -c CONFLICTS`"" -eq 1; then
+    if test ""`echo $supportedTags | grep -c CONFLICTS`"" -eq 1; then
        tag_CONFLICTS=""|CONFLICTS=%{CONFLICTS}""
     else
        tag_CONFLICTS=""""
}}}

However, I suggest we remove the conditional altogether:

The conditional implies that in days past ""CONFLICTS"" wasn't a known tag to 'rpm', and that therefore 'rpm -qp --qf %{CONFLICTS} some_package.rpm' would raise an error -- something against which we need to protect.

But, looking in the helper's source code, we see other tags we use without protection and while I'm not familiar with 'rpm', I wonder why we assume **they** are ""old and safe"". Surely the ones we added recently (PRETRANS, ...) aren't that old.

== Some other observations:

* CONFLICTS support was added in 16bf1ca415c3f7 (year 2006), ''without protection'', by somebody with an email from redhat.com. Perhaps we may rely on his ""authority""?

* The protection, together with the bug, was added in e7ed071be7f (#1590, year 2009) without explanation as part of a ""total rewrite"" of the script. I don't see people doing code review in that ticket.

* We're still using CONFLICTS ''without protection'' in the 'trpm' helper.

== To sum it up:

Should we add a ""$"", or remove the conditional altogether?
"	defect	closed	major	4.8.21	mc-vfs	master	fixed		slavazanko			merged	committed-master