Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting for apache hive #3828

Closed
mc-butler opened this issue Jun 14, 2017 · 12 comments
Closed

syntax highlighting for apache hive #3828

mc-butler opened this issue Jun 14, 2017 · 12 comments
Assignees
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3828
Reporter mlorek (michal.lorek@….com)
Keywords hive, hql, syntax

Hi,

would it be possible to add syntax highlighting for apache hive scripts?

I have already prepared relevant files which can be found here:

https://github.com/mlorek/mc/tree/hive_syntax

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 14, 2017 at 18:44 UTC (comment 1)

file ..\*\\.(hql|HQL)$ SQL\sProgram
include hive.syntax

Is it really SQL Program?

@mc-butler
Copy link
Author

Changed by mlorek (michal.lorek@….com) on Jun 14, 2017 at 19:05 UTC (comment 1.2)

Replying to andrew_b:

file ..\*\\.(hql|HQL)$ SQL\sProgram
include hive.syntax

Is it really SQL Program?

well, it is a text script executed against Hive.
and hql is a dialect of sql.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 14, 2017 at 19:44 UTC (comment 3)

Andrew, OK to commit if SQL -> HiveQL?

Only I'm a bit bothered by commented out operators. Why?

@mc-butler
Copy link
Author

Changed by mlorek (michal.lorek@….com) on Jun 14, 2017 at 20:05 UTC (comment 3.4)

Replying to zaytsev:

Andrew, OK to commit if SQL -> HiveQL?

Only I'm a bit bothered by commented out operators. Why?

This was work in progress and I did not know you guys use tickets.
I cleaned that section up a bit and pushed another version.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 15, 2017 at 6:39 UTC (comment 3.5)

Replying to zaytsev:

Andrew, OK to commit if SQL -> HiveQL?

OK.

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 15, 2017 at 7:35 UTC (comment 6)

  • Milestone changed from Future Releases to 4.8.20
  • Owner set to zaytsev
  • Status changed from new to accepted

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 15, 2017 at 19:16 UTC (comment 7)

Branch: 3828_hive_syntax
Initial [bb7be7]

I still see some commented out stuff. Is this finished now? If not, please add a final commit to your branch and I will rebase.

@mc-butler
Copy link
Author

Changed by mlorek (michal.lorek@….com) on Jun 16, 2017 at 7:09 UTC (comment 7.8)

Replying to zaytsev:

Branch: 3828_hive_syntax
Initial [bb7be7]

I still see some commented out stuff. Is this finished now? If not, please add a final commit to your branch and I will rebase.

It is finished now. All changes are part of the following branch:

https://github.com/mlorek/mc/tree/hive_syntax

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 16, 2017 at 11:50 UTC (comment 9)

  • Status changed from accepted to testing
  • Branch state changed from no branch to merged
  • Resolution set to fixed

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 16, 2017 at 12:06 UTC (comment 10)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 21, 2017 at 7:38 UTC (comment 11)

Merged to master: [bc961db].

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Jun 21, 2017 at 19:24 UTC (comment 12)

Sorry, forgot about it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: mcedit mcedit, the built-in text editor prio: low Minor problem or easily worked around
Development

No branches or pull requests

2 participants