Changed by andrew_b (@aborodin) on Feb 1, 2021 at 5:25 UTC (comment 1)

• Milestone Future Releases deleted
• Status changed from new to closed
• Resolution set to invalid

This is the result of #4128. You should synchronize your local ~/.config/mc/mc.ext with system-wide /etc/mc/mc.ext.

See also #4180, #4183.

Changed by onlyjob (@onlyjob) on Feb 1, 2021 at 5:29 UTC (comment 2)

• Status changed from closed to reopened
• Resolution invalid deleted
• Cc set to onlyjob@….fsf.org

No I think it is a different issue.
For several years I have XZ_OPT environment variable set as follows:

XZ_OPT=-6v

Before 4.8.26 that was not causing any problems...

MC-4.8.26 can enter .tar.xz archives if started as follows:

XZ_OPT="" mc

Changed by andrew_b (@aborodin) on Feb 1, 2021 at 6:13 UTC (comment 3)

MC doesn't know anything about XZ_OPT.

Changed by andrew_b (@aborodin) on Feb 1, 2021 at 6:19 UTC (comment 4)

Before 4.8.26:

$ file -L test.tar.xz 
test.tar.xz: xz compressed data

4.8.26:

$ file -L -z test.tar.xz 
test.tar.xz: POSIX tar archive (GNU) (xz compressed data)

Please update your ~/.config/mc/mc.ext.

Changed by onlyjob (@onlyjob) on Feb 1, 2021 at 6:24 UTC (comment 5)

Of course I did update my mc.ext, as advised, and could reproduce the problem still - that's why I've re-opened the issue.

XZ_OPT modifies output of the xz. I think MC is confused by "-v" part that prints extraction progress to STDERR. Formerly STDERR was captured, presented to user and I had to dismiss it with a brief keystroke, but it did not cause failure hence former behaviour was more robust.

Changed by zaytsev (@zyv) on Feb 1, 2021 at 7:21 UTC (comment 6)

That's weird, I can't remember any patches messing with stderr - probably need to blame.

Changed by andrew_b (@aborodin) on Feb 3, 2021 at 7:27 UTC (comment 7)

Bad commit is [61f997d].

Changed by onlyjob (@onlyjob) on Feb 3, 2021 at 10:54 UTC (comment 8)

Thank you for troubleshooting, Andrew.

Changed by andrew_b (@aborodin) on Feb 7, 2021 at 12:47 UTC (comment 9)

• Milestone set to 4.8.27
• Status changed from reopened to accepted
• Branch state changed from no branch to on review
• Owner set to andrew_b

Branch: 4191_tar.xz
Initial [a5036e0256f9041f2f42345778388cdb6bcda83f]

Changed by ossi (@ossilator) on Feb 8, 2021 at 9:55 UTC (comment 10)

that's some bizarre code. why not use dup2 properly right away?

Changed by andrew_b (@aborodin) on Feb 28, 2021 at 13:37 UTC (comment 11)

• Branch state changed from on review to on rework

Changed by andrew_b (@aborodin) on Mar 6, 2021 at 8:12 UTC (comment 12)

• Branch state changed from on rework to on review

Read of stdout/stderr of child process is reimplemented using mc_pipe engine.

Branch: 4191_tar.xz
Initial [99ac6d4207f5f7072b3524eeeb742ff657aef9ba]

Changed by ossi (@ossilator) on Mar 6, 2021 at 13:11 UTC (comment 13)

is there a way to sensibly comment on the patches? i really don't feel like specifying the sha1, file, and line number for every issue i see ...

Changed by andrew_b (@aborodin) on Mar 6, 2021 at 15:31 UTC (comment 14)

On GitHub?
https://github.com/MidnightCommander/mc/commits/4191_tar.xz

Changed by andrew_b (@aborodin) on Mar 14, 2021 at 16:18 UTC (comment 15)

• Votes set to andrew_b
• Branch state changed from on review to approved

Changed by andrew_b (@aborodin) on Mar 14, 2021 at 16:20 UTC (comment 16)

• Resolution set to fixed
• Status changed from accepted to testing
• Branch state changed from approved to merged
• Votes changed from andrew_b to committed-master

Merged to master: [3189815].

git log --pretty=onelin ff0949ece..318981535

Changed by andrew_b (@aborodin) on Mar 14, 2021 at 16:21 UTC (comment 17)

• Status changed from testing to closed