Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable xterm_flag in screen and tmux even without DISPLAY #4233

Closed
mc-butler opened this issue Apr 13, 2021 · 6 comments
Closed

Enable xterm_flag in screen and tmux even without DISPLAY #4233

mc-butler opened this issue Apr 13, 2021 · 6 comments
Assignees
@aborodin
Labels
area: tty Interaction with the terminal, screen libraries prio: medium Has the potential to affect progress
Milestone
4.8.27

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4233
Reporter filip.hejsek (filip.hejsek@….com)

Currently, the xterm_flag, and therefore mouse support, is only enabled with TERM=screen when the DISPLAY variable is set to nonempty value. However, this is not always the case (for example when using srceen/tmux over ssh), and the absence of the DISPLAY variable doesn't mean the terminal doesn't support mouse. The correct thing to do is to always enable mouse support under screen/tmux.

Additionally, while tmux by default sets TERM to "screen" for compatibility, it also supports "tmux" and "tmux-256color", so these should be detected too.

I was about to submit a pull request on github, but then i saw the message that you don't use github pull requests, so i submitted this ticket instead. The commit is here: https://github.com/filip-hejsek/mc/commit/01c7047ac4c6cd8595448b51dd45d6f769cf43db
@mc-butler
Copy link
Author

Changed by filip.hejsek (filip.hejsek@….com) on Apr 13, 2021 at 14:34 UTC (comment 1)

  • Summary changed from Enable xterm_flag in more screen and tmux even without DISPLAY to Enable xterm_flag in screen and tmux even without DISPLAY

@mc-butler
Copy link
Author

Changed by filip.hejsek (filip.hejsek@….com) on Jun 9, 2021 at 19:31 UTC (comment 2)

Ping?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jun 12, 2021 at 14:12 UTC (comment 3)

  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.27
  • Owner set to andrew_b
  • Branch state changed from no branch to on review

Branch: 4233_screen_tmux_mouse
Initial [57a5db64ca8dc3f562bc223a053671c160d1f8f7]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 4, 2021 at 15:50 UTC (comment 4)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 4, 2021 at 15:55 UTC (comment 5)

  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Status changed from accepted to testing
  • Branch state changed from approved to merged

Merged to master: [5c1d3c5].

git log --pretty=oneline 0e6721c32..5c1d3c55d

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 4, 2021 at 15:57 UTC (comment 6)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: tty Interaction with the terminal, screen libraries prio: medium Has the potential to affect progress
Milestone
4.8.27
Development

No branches or pull requests
2 participants
@aborodin @mc-butler