Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP: the month of file creation is always January #4260

Closed
mc-butler opened this issue Jul 13, 2021 · 5 comments
Closed

FTP: the month of file creation is always January #4260

mc-butler opened this issue Jul 13, 2021 · 5 comments
Assignees
@aborodin
Labels
area: vfs Virtual File System support prio: low Minor problem or easily worked around ver: 4.8.26 Reproducible in version 4.8.26
Milestone
4.8.27

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4260
Reporter m_ok (dddg4447@….com)
Keywords ftpfs, date, ftp

When browsing FTP servers, the files' dates always have January as a month. I found the location of this problem. In the file src/mc/src/vfs/ftpfs/ftpfs_parse_ls.c:

      if (vfs_parse_month (t, &date))
          date.tm_mon = 0;

should be changed to 

      if (!vfs_parse_month (t, &date))
          date.tm_mon = 0;

The version is 4.8.26-221-g0c04e2382.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2021 at 18:03 UTC (comment 1)

  • Owner set to andrew_b
  • Version changed from master to 4.8.26
  • Milestone changed from Future Releases to 4.8.27
  • Status changed from new to accepted
  • Description edited

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2021 at 18:31 UTC (comment 2)

  • Branch state changed from no branch to on review

Thanks!

Branch: 4260_ftp_file_month
[36e48b0]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2021 at 18:33 UTC (comment 3)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2021 at 18:34 UTC (comment 4)

  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master

Merged to master: [fa9ea0d].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jul 13, 2021 at 18:35 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: vfs Virtual File System support prio: low Minor problem or easily worked around ver: 4.8.26 Reproducible in version 4.8.26
Milestone
4.8.27
Development

No branches or pull requests
2 participants
@aborodin @mc-butler