id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	blockedby	blocking	branch_state	votes
4391	Delete editor macro results in infinite loop	sxmboer2	andrew_b	"Since version 4.8.27 removing an existing macro results in an infinite loop that dumps a repeating series of array assertion error.

To reproduce:
create a macro, e.g. CTRL-R abc CTRL-R a
remove that macro, e.g. CTRL-R CTRL-R a (or use the menu to delete that macro)

The problem was introduced because of the split of the macro functions with some rewrites and optimizations. I am including a patch that also gets rid of the unnecessary resorting of the macro array. The glib function called keeps the array sorted.
Another thought is that the while construction can be replaced with a single if. In principle it is impossible to have more than one macro with the same hotkey.

"	defect	closed	major	4.8.29	mcedit	master	fixed	macro edit				merged	committed-master