id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	blockedby	blocking	branch_state	votes
4433	Allow setting color for abnormal characters in editor from skin file	ArtemKuchin	andrew_b	"in editdraw.c

{{{
/* If non-printable - use black background */
color = (style & MOD_ABNORMAL) != 0 ? 0 : p->style >> 16;
}}}

So, if, for example, file contains CR (`^M`)  i see a lot of `^M` on black background tearing apart all my nice colors and poking my eyes out. 
It would be nice to have something like editabnormal in skin file to set it to something noticeable but nice.

I tried adding it myself

skin.h
{{{
#define EDITOR_ABNORMAL_COLOR     mc_skin_color__cache[50]
#define MC_SKIN_COLOR_CACHE_COUNT 68
}}}
and renumbered cache array

colors.c
{{{
EDITOR_ABNORMAL_COLOR = mc_skin_color_get (""editor"", ""editabnormal"");
}}}
editdraw.c 
{{{
        else
            //tty_setcolor (EDITOR_ABNORMAL_COLOR);
            tty_lowlevel_setcolor (color);
}}}
But it does not work somehow. Compiles fine but just does not work. Abnormal chars just show as normal.




"	enhancement	closed	minor	4.8.31	mc-skin	master	fixed	color abnormal non printable skin				merged	committed-master