Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make dist" failed with error in "po" dir #4466

Closed
mc-butler opened this issue May 21, 2023 · 7 comments
Closed

"make dist" failed with error in "po" dir #4466

mc-butler opened this issue May 21, 2023 · 7 comments
Assignees
@aborodin
Labels
area: build Build system and (cross-)compilation prio: medium Has the potential to affect progress
Milestone
4.8.30

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4466
Reporter karlson2k (karlson2k@….com)

This is a follow-up for #4459.

po directory needs to be treated specially. It does not fully use automake macros and SED is not substituted in generated Makefiles.
The only way to add new automatically substituted variable to the Makefile is to add it to Makefile.in.in, however this file is replaced automatically by autopoint (with -f flag).
All other files, like Makevars or Rules-pot-defaults, are not processed by configure for variable substitution.
The best way to use sed command in this dir is to rely on shell automatic substitution. It does not use sed found by configure, but the script is portable enough, so with the suggest patch "make dist" works without overcomplication.

The suggested fix: #191

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by karlson2k (karlson2k@….com) on May 21, 2023 at 14:20 UTC

Suggested fix

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 21, 2023 at 16:40 UTC (comment 1)

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.30

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 21, 2023 at 17:26 UTC (comment 2)

  • Branch state changed from no branch to on review

Branch: 4466_sed.
[1d7d9a8]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 21, 2023 at 17:26 UTC (comment 3)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 21, 2023 at 17:27 UTC (comment 4)

  • Branch state changed from approved to merged
  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed
  • Status changed from accepted to testing

Thanks!

Merged to master: [ec3f142].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 21, 2023 at 17:28 UTC (comment 5)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by karlson2k (karlson2k@….com) on May 22, 2023 at 7:21 UTC (comment 6)

You are welcome.

I've tested the git master. Now dist could be made (tested on Debian Sid) and then mc could be built on Solaris.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: build Build system and (cross-)compilation prio: medium Has the potential to affect progress
Milestone
4.8.30
Development

No branches or pull requests
2 participants
@aborodin @mc-butler