Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midnight Commander Git (Today) Tar component segfaults #4598

Closed
mc-butler opened this issue Oct 10, 2024 · 7 comments
Closed

Midnight Commander Git (Today) Tar component segfaults #4598

mc-butler opened this issue Oct 10, 2024 · 7 comments
Assignees
@aborodin
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.33

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4598
Reporter Axanar (aliakc@….de)

Hi there.

I've been using the Git version of Midnight Commander for a few days, after we got the TAR compilation issue fixed - due the TAR update.

Although. The VFS System tends to segfault now. Sometimes it works, sometimes it won't. I roughly testet this with a bunch of files now.

Fedora 41

The TAR file that causes segfaults here can be found here:

https://freedesktop.org/software/pulseaudio/pavucontrol/
http://freedesktop.org/software/pulseaudio/pavucontrol/pavucontrol-6.1.tar.gz

Start MC, select and click on the file and it segfaults.

Normal tar cfzv works perfectly on that file.

Any thoughts?

Note

Original attachments:

  • log.txt (raw) by Axanar (aliakc@….de) on Oct 10, 2024 at 15:42 UTC
@mc-butler
Copy link
Author

Changed by Axanar (aliakc@….de) on Oct 10, 2024 at 15:42 UTC

Full backtrace of captured coredump

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 10, 2024 at 17:46 UTC (comment 1)

  • Status changed from new to accepted
  • Component changed from mc-core to mc-vfs
  • Milestone changed from Future Releases to 4.8.33
  • Owner set to andrew_b

Bad [7d8deb8].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 10, 2024 at 18:18 UTC (comment 2)

  • Branch state changed from no branch to on review

Thanks for testing!

Branch: 4598_tar_segfault
Initial [d1863c00618987f736373ac00b57908f910663cd]

@mc-butler
Copy link
Author

Changed by Axanar (aliakc@….de) on Oct 10, 2024 at 22:01 UTC (comment 2.3)

Replying to andrew_b:

Thanks for testing!

Branch: 4598_tar_segfault
Initial [d1863c00618987f736373ac00b57908f910663cd]

I've tested the Branch with a bunch of tar files and so far everything works!

Thanks!

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 11, 2024 at 6:07 UTC (comment 4)

  • Votes set to zaytsev
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 11, 2024 at 14:39 UTC (comment 5)

  • Resolution set to fixed
  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Votes changed from zaytsev to committed-master

Merged to master: [54a4c7d].

git log --oneline b294d650a..54a4c7d55

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 11, 2024 at 14:40 UTC (comment 6)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.8.33
Development

No branches or pull requests
2 participants
@aborodin @mc-butler