mcedit input text issue

[angel_il]

in insert mode? mcedit incorrect replace utf-8 text.
for reproduce:
input test like this 'йцукенг' in utf-8
move cursor at start of line
press key <Ins>
input new text.

[dmartina]

I noticed too:

• In mcedit
• In overwite mode (press Ins)
• When trying to overwrite a multibyte UTF-8 (non ASCII) character, just the first byte is replaced.
• The second, orphan, meaningless byte stays.

Something easy:

1 €uro

And try to overwrite the '€' with a plain 'e'.

[angel_il]

branch: 1411_insert_issue (parent: master)
changeset: ffdeb28b3bfbfa6242fd41a247f87133115c493a

[iNode]

Yes it's fix the problem but some related old code seems ugly, I propose to do small refactoring.
i.e. edit.c:edit_delete:

p = edit->buffers2[(edit->curs2 - 1) >> S_EDIT_BUF_SIZE][EDIT_BUF_SIZE - ((edit->curs2 - 1) & M_EDIT_BUF_SIZE) - 1];

too long

    ... const int byte_delete
    /* if byte_delete = 1 then delete only one byte not multibyte char*/

should be gboolean.

edit.c:edit_get_utf

            if ( next_ch != str ) {
                width = next_ch - str;
            } else {
                width = 0;
            }

Any way next_ch - str equal width or 0, useless if.

Thanks.

[angel_il]

but some related old code seems ugly, I propose to do small refactoring.

ok, but not in this ticket

[angel_il]

rebased: 0a594b7cc028ca31a2f1dc4b3fa6395ead4b67c6 (forced update)

[angel_il]

Fixed: 00200124ddd118a42505c798f1536ad8fe76e026