Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcedit: optional different background for columns > 80 #1514

Closed
mc-butler opened this issue Aug 9, 2009 · 25 comments
Closed

mcedit: optional different background for columns > 80 #1514

mc-butler opened this issue Aug 9, 2009 · 25 comments
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.7.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1514
Reporter sergey-feo (sergey-feo@….ru)

In programming good style is do not exceed 80 columns.
It will be good if mcedit will have option for different background color for columns 81 and righter.

You can see examples in attached files.

Note

Original attachments:

  • 80qtc.gif (raw) by sergey-feo (sergey-feo@….ru) on Aug 9, 2009 at 18:13 UTC
  • 80.gif (raw) by sergey-feo (sergey-feo@….ru) on Aug 9, 2009 at 18:14 UTC
@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Aug 9, 2009 at 18:13 UTC

qt designer with 80 columns delimiter

@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Aug 9, 2009 at 18:14 UTC

How can it looks in mcedit

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 10, 2009 at 5:25 UTC

Replying to sergey-feo (#1514):

How can it looks in mcedit

are you really need this?

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 10, 2009 at 5:26 UTC (comment 2)

  • Status changed from new to accepted
  • Owner set to angel_il

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 10, 2009 at 5:28 UTC (comment 3)

  • Milestone changed from future releases to 4.7

@mc-butler
Copy link
Author

Changed by sergey-feo (sergey-feo@….ru) on Aug 10, 2009 at 17:48 UTC (comment 4)

are you really need this?

I can live without this, but with this feature life is better :-)
Please note that old Borland C++ Builder 6 also have feature like this.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Sep 30, 2009 at 6:25 UTC (comment 5)

  • Milestone changed from 4.7 to 4.7.0-pre4

@mc-butler
Copy link
Author

Changed by NNemec (@NNemec) on Oct 22, 2009 at 8:53 UTC (comment 6)

I agree that this would be a really helpful feature. I am working on a project where the 80char limit is strict policy. I don't know how often a simple visual help like the one suggested would have helped preventing policy violations.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Oct 22, 2009 at 9:58 UTC (comment 7)

  • Milestone changed from 4.7.0-pre4 to 4.7

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Nov 19, 2009 at 12:39 UTC (comment 8)

branch: 1514_over_wrap_line
changeset: [aafd9353ab45a00c32ff90a52c6235a6caec5631]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 3, 2010 at 1:58 UTC (comment 9)

  • Severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.1

changeset: [ef4b02eeda68d94c18d96087e1f23526ca8719c8]

please review

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 3, 2010 at 9:32 UTC (comment 10)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 6, 2010 at 9:42 UTC (comment 11)

  • Severity changed from on review to approved
  • Votes changed from andrew_b to andrew_b slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 6, 2010 at 11:33 UTC (comment 12)

  • Resolution set to fixed
  • Votes changed from andrew_b slavazanko to committed-master
  • Status changed from accepted to testing
  • Severity changed from approved to merged

Fixed: [287255b]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 6, 2010 at 15:18 UTC (comment 13)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 13, 2010 at 6:34 UTC (comment 14)

  • Status changed from closed to reopened
  • Votes committed-master deleted
  • Resolution fixed deleted

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 13, 2010 at 6:37 UTC (comment 15)

reason: http://mail.gnome.org/archives/mc-devel/2010-January/msg00035.html

One with curtsor position at 71'th character, another at 72'th position.

The background suddenly becomes black.

--
Janek Kozicki

screenshot: http://mail.gnome.org/archives/mc-devel/2010-January/pngytUgAUOM8q.png

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 13, 2010 at 10:02 UTC (comment 16)

  • Severity changed from merged to on review

branch: 1514_right_margin_fix
changeset: [b8ee28c2fd806c2ae6a9d1e813b29bb74f285238]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 13, 2010 at 12:57 UTC (comment 17)

  • Votes set to andrew_b
  • Type changed from enhancement to defect
  • Version changed from 4.7.0-pre1 to master

@mc-butler
Copy link
Author

Changed by metux (@metux) on Jan 14, 2010 at 1:28 UTC (comment 18)

rebased and running through testfarm.

i'll vote if it passes all build-tests.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 14, 2010 at 11:19 UTC (comment 19)

  • Status changed from reopened to assigned
  • Votes changed from andrew_b to andrew_b slavazanko
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by metux (@metux) on Jan 15, 2010 at 0:22 UTC (comment 20)

  • Votes changed from andrew_b slavazanko to committed-master
  • Severity changed from approved to merged

@mc-butler
Copy link
Author

Changed by metux (@metux) on Jan 15, 2010 at 0:22 UTC (comment 21)

  • Resolution set to fixed
  • Status changed from assigned to testing

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 15, 2010 at 5:30 UTC (comment 22)

fixed: [d9384a6]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 20, 2010 at 8:52 UTC (comment 23)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.7.1
Development

No branches or pull requests
1 participant
@mc-butler