Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darker color style #1659

Closed
mc-butler opened this issue Oct 3, 2009 · 17 comments
Closed

Darker color style #1659

mc-butler opened this issue Oct 3, 2009 · 17 comments
Assignees
Labels
area: skin Theming support and skin files prio: low Minor problem or easily worked around ver: 4.7.0-pre3 Reproducible in version 4.7.0-pre3
Milestone

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1659
Reporter gotar (gotar@….pl)

I've just finished translating my color style into new skin format. It's more suitable for working in dark rooms as it's not so bright as default one. Feel free to redistribute it.

Note

Original attachments:

  • gotar.ini (raw) by gotar (gotar@….pl) on Oct 3, 2009 at 8:54 UTC
  • gotar.2.ini (raw) by gotar (gotar@….pl) on Oct 22, 2009 at 13:29 UTC
  • gotar.patch (raw) by gotar (gotar@….pl) on Oct 30, 2009 at 23:23 UTC
@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Oct 3, 2009 at 8:54 UTC

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 3, 2009 at 9:08 UTC (comment 1)

  • Status changed from new to accepted
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Oct 22, 2009 at 13:29 UTC

updated according to #1667

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 27, 2009 at 20:41 UTC (comment 2)

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Milestone changed from 4.7 to 4.7.0-pre4

directly in master: [6d5cccc]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Oct 27, 2009 at 20:41 UTC (comment 3)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Oct 30, 2009 at 23:23 UTC

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Oct 30, 2009 at 23:30 UTC (comment 4)

  • Status changed from closed to reopened
  • Resolution fixed deleted

Attached patch against #1703 (commited changes in this skin were obviously not checked...). And I'd like to point out #1670.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 9, 2009 at 10:51 UTC (comment 5)

  • Milestone changed from 4.7.0-pre4 to 4.7

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 25, 2009 at 15:53 UTC (comment 6)

  • Status changed from reopened to accepted

From patch:

+hotkey=lightgray.black 

Why dot between colors?

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Nov 25, 2009 at 15:56 UTC (comment 7)

Must be just typo (and falls to defaults which is the same).

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 26, 2009 at 9:16 UTC (comment 8)

  • Severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

Created branch 1659_darker_color_style.

Initial [6ab746a7e91963d2a1586b0b2977c31782fe2ae2]

Review, please.

P.S. To all: I have idea... IMHO, need to remove all skins and keymaps from repo (exclude default skin and keymaps). All third-party files will plased into wiki-pages (as attachment).

Is this good idea?

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 26, 2009 at 9:17 UTC (comment 9)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by gotar (gotar@….pl) on Nov 26, 2009 at 14:38 UTC (comment 10)

Changeset is fine.
As for additional skins and resources I don't think it is a good idea:

  1. no updates when new elements appear,
  2. no resources in tarballs (being also a distro packager I doubt anyone would fetch anything from wiki)

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Nov 26, 2009 at 17:37 UTC (comment 11)

  • Severity changed from on review to approved
  • Votes changed from slavazanko to slavazanko andrew_b

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 27, 2009 at 7:40 UTC (comment 12)

  • Severity changed from approved to merged
  • Votes changed from slavazanko andrew_b to commited-master

Merge [d97f55d]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 27, 2009 at 7:40 UTC (comment 13)

  • Resolution set to fixed
  • Status changed from accepted to testing

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Nov 27, 2009 at 7:40 UTC (comment 14)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: skin Theming support and skin files prio: low Minor problem or easily worked around ver: 4.7.0-pre3 Reproducible in version 4.7.0-pre3
Development

No branches or pull requests

2 participants