Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning on unused code in src/strutilutf8.c #1913

Closed
mc-butler opened this issue Dec 29, 2009 · 11 comments
Closed

Warning on unused code in src/strutilutf8.c #1913

mc-butler opened this issue Dec 29, 2009 · 11 comments
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.7.0.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1913
Reporter metux (@metux)

src/strutilutf8.c defines str_utf8_key_collate(), which is never used.

This produces warnings, together w/ -Werror breaks the build.

branch:1913_unused_strfunc
[caf4f5e184c72a325e56a72ba6134defd6843685]
@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 2:59 UTC (comment 1)

  • Status changed from new to accepted
  • Description edited
  • Severity changed from no branch to on review
  • Owner set to metux

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 3:06 UTC (comment 2)

  • Version changed from version not selected to master

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 29, 2009 at 5:33 UTC (comment 3)

  • Description edited

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 29, 2009 at 5:39 UTC (comment 4)

Ctreating the user-defined macro started with two undelines is not a good practice.

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 6:59 UTC (comment 4.5)

Replying to andrew_b:

Ctreating the user-defined macro started with two undelines is not a good practice.

okay, feel free to change it ;-p

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 29, 2009 at 12:43 UTC (comment 6)

  • Milestone changed from 4.7 to 4.7.0.1
  • [04acce9568b6e2e737c89f63ec9280806837bf4c]: Renamed constant USE_STR_UTF8_CREATE_KEY_FOR_FILENAME to MCUSE_STR_UTF8_CREATE_KEY_FOR_FILENAME

review

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 29, 2009 at 19:33 UTC (comment 7)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 30, 2009 at 5:44 UTC (comment 8)

  • Severity changed from on review to approved
  • Votes changed from angel_il to angel_il andrew_b

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 30, 2009 at 8:47 UTC (comment 9)

  • Severity changed from approved to merged
  • Votes changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • Status changed from accepted to testing

merge [9b81b9bd7df3ddc90f4a4dc838b62258602c06e4]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 30, 2009 at 8:47 UTC (comment 10)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 30, 2009 at 8:54 UTC (comment 11)

Sorry, merge [f3b6436]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.7.0.1
Development

No branches or pull requests
1 participant
@mc-butler