Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VFS configure fixups #1916

Closed
mc-butler opened this issue Dec 29, 2009 · 15 comments
Closed

VFS configure fixups #1916

mc-butler opened this issue Dec 29, 2009 · 15 comments
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.0.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1916
Reporter metux (@metux)
  • Some long time ago, parts of MVFS development branch have been accidentially merged.
  • some AC_CONDITIONAL()'s are missing for non-vfs builds.
  • several conflicts between vfs/vfs.h and src/vfsdummy.h
  • missing functions on non-vfs builds

branch:1916_nonvfs_fixup
[d8b370d973acf7ae265ab57918cb5e151ca58031]
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 29, 2009 at 5:30 UTC (comment 1)

What about #1910?

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 29, 2009 at 5:44 UTC (comment 2)

  • Blocked by set to #1910

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 6:56 UTC (comment 1.3)

  • Owner set to metux
  • Status changed from new to accepted

Replying to andrew_b:

What about #1910?

Thats included in here.
I'm currently doing the last cleanups to get the branch ready for review.

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 7:39 UTC (comment 4)

  • Blocked by #1910 deleted
  • Description edited
  • Severity changed from no branch to on review

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 29, 2009 at 10:12 UTC (comment 5)

  • Severity changed from on review to on rework
  • Component changed from mc-core to mc-vfs

./configure --help shows

  --disable-vfs           Compile with VFS code

Should be

  --disable-vfs           Compile without VFS code

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 11:15 UTC (comment 5.6)

Replying to andrew_b:

./configure --help shows

  --disable-vfs           Compile with VFS code

Should be

  --disable-vfs           Compile without VFS code

Fixed it.

@mc-butler
Copy link
Author

Changed by metux (@metux) on Dec 29, 2009 at 11:15 UTC (comment 7)

  • Severity changed from on rework to on review

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 29, 2009 at 13:33 UTC (comment 8)

  • Votes set to slavazanko
  • Milestone changed from 4.7 to 4.7.0.1

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 29, 2009 at 13:50 UTC (comment 9)

  • Severity changed from on review to on rework

[73b2790ae7967fdebde3327a41ce0f536ca37cc4]
vfs_canon_and_translate() should be rewritten using glib functions.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 29, 2009 at 14:05 UTC (comment 10)

  • Votes slavazanko deleted
  • [b0e4b779e6a88d2a353289323f26b7d910d8aad0]: Rewritten vfs_canon_and_translate() function for using glib functions.

Review, please.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 29, 2009 at 14:26 UTC (comment 11)

  • Severity changed from on rework to on review

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Dec 29, 2009 at 20:05 UTC (comment 12)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Dec 30, 2009 at 5:43 UTC (comment 13)

  • Severity changed from on review to approved
  • Votes changed from angel_il to angel_il andrew_b

Please squash [73b2790ae7967fdebde3327a41ce0f536ca37cc4] and [b0e4b779e6a88d2a353289323f26b7d910d8aad0] before merge.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 30, 2009 at 8:59 UTC (comment 14)

  • Status changed from accepted to testing
  • Severity changed from approved to merged
  • Votes changed from angel_il andrew_b to commited-master
  • Resolution set to fixed

merge [00f3857]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Dec 30, 2009 at 8:59 UTC (comment 15)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.0.1
Development

No branches or pull requests
1 participant
@mc-butler