Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor beyond EOL has unusual default #1946

Closed
mc-butler opened this issue Jan 9, 2010 · 19 comments
Closed

Cursor beyond EOL has unusual default #1946

mc-butler opened this issue Jan 9, 2010 · 19 comments
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.7.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/1946
Reporter tillea (tillea@….com)

Hi,
with the current default setting of cursor_beyond_eol mcedit is behaving different than any other editor I know which IMHO at least a badly choosen default behaviour. I would strongly vote to keep the original behaviour and leave this new (??) behaviour as a configuration option especially because it is not really obvious to find this option.
Kind regards

Andreas.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 9, 2010 at 10:02 UTC (comment 1)

  • Component changed from mc-core to mcedit
  • Version changed from version not selected to 4.7.0

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jan 9, 2010 at 14:46 UTC (comment 2)

do you mean ticket 1801 by any chance?

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 9, 2010 at 21:03 UTC (comment 3)

I would strongly vote to keep the original behaviour...

by default you have original behaviour, this option switced off by default, just do not turned on.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 9, 2010 at 21:07 UTC (comment 4)

and... what you mean when you say "other editor"?

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 9, 2010 at 21:13 UTC (comment 5)

and... all new features switched off by default.

@mc-butler
Copy link
Author

Changed by tillea (tillea@….com) on Jan 9, 2010 at 22:47 UTC (comment 2.6)

Replying to ossi:

do you mean ticket 1801 by any chance?

Uhm yes. Sorry for bad research in advance

Andreas.

@mc-butler
Copy link
Author

Changed by tillea (tillea@….com) on Jan 9, 2010 at 22:49 UTC (comment 4.7)

Replying to angel_il:

and... what you mean when you say "other editor"?

Any editor I ever have used in > 25 years. I never have seen an editor where I can "navigate in the void" and I do not have the slightest idea for what this is useful.

Andreas.

@mc-butler
Copy link
Author

Changed by ossi (@ossilator) on Jan 9, 2010 at 23:29 UTC (comment 8)

hmmm, no, we're not talking about the same thing then. the "navigation in the void" is (or at least was) a pretty common feature in programmers' editors, like the good ol' borland dos IDEs. i only object to the fact that it does not behave like in these ...

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 10, 2010 at 7:49 UTC (comment 5.9)

Replying to angel_il:

and... all new features switched off by default.

Really? :) This feature in ON.

edit/edit.c:78

int option_cursor_beyond_eol = 1;

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 10, 2010 at 13:48 UTC (comment 9.10)

Replying to andrew_b:

Replying to angel_il:

and... all new features switched off by default.

Really? :) This feature in ON.

edit/edit.c:78

int option_cursor_beyond_eol = 1;

ok, need fix it :)

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 10, 2010 at 14:21 UTC (comment 7.11)

Replying to tillea:

Replying to angel_il:

and... what you mean when you say "other editor"?

Any editor I ever have used in > 25 years.

ok, borland editors, far editor, emacs, lazarus, notepad++, codeblock, vim... and many many editors...

I never have seen an editor where I can "navigate in the void" and I do not have the slightest idea for what this is useful.

just try select vertical block with/without this option... feel different...

...and this options will be switched of by default...

@mc-butler
Copy link
Author

Changed by tillea (tillea@….com) on Jan 10, 2010 at 17:29 UTC (comment 11.12)

Replying to angel_il:

ok, borland editors, far editor, emacs, lazarus, notepad++, codeblock, vim... and many many editors...

It might be that all these editors might have an option to change their behaviour but if I'm at the end of a line and press the <right-arrow> key I end up in the next line or the cursor just stops there and not in an area where the edited file has no characters at all.

just try select vertical block with/without this option... feel different...

Working with vertical blocks is a specific modus. Works perfect for instance with Emacs if you insert some spaces in the first / last line if needed - I do not remember how all the other editors behave in this modus.

...and this options will be switched of by default...

That's great and was the issue of my bug report.
Thanks

Andreas.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 20, 2010 at 11:14 UTC (comment 13)

  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.7.1
  • Version changed from 4.7.0 to master
  • Owner set to angel_il

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 20, 2010 at 11:23 UTC (comment 14)

  • Severity changed from no branch to on review

branch: 1946_cursor_beyond_EOL_fix
changeset: [8d62484b725416686de5a410b390acc668189c27]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Jan 20, 2010 at 11:38 UTC (comment 15)

  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 21, 2010 at 7:53 UTC (comment 16)

  • Votes changed from andrew_b to andrew_b slavazanko
  • Severity changed from on review to approved

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 21, 2010 at 13:03 UTC (comment 17)

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Votes changed from andrew_b slavazanko to committed-master
  • Severity changed from approved to merged

fixed: [734eff6]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Jan 21, 2010 at 13:06 UTC (comment 18)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Jan 21, 2010 at 15:37 UTC (comment 19)

  • Votes changed from committed-master to committed-master commited-stable

stable: [fc020c3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.7.1
Development

No branches or pull requests
1 participant
@mc-butler