Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] Don't try to make directory NULL named in mkdir_cmd() #2014

Closed
mc-butler opened this issue Feb 9, 2010 · 8 comments
Closed

[PATCH] Don't try to make directory NULL named in mkdir_cmd() #2014

mc-butler opened this issue Feb 9, 2010 · 8 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.7.2

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2014
Reporter cosoleto (cosoleto@….com)

As input_expand_dialog() may return a pointer to an empty string,
the function was trying to create a directory so named and thus
print a false "File exists" error message.
This is a regression due to commit [350c958] dated 4 Feb 2006, previously fixed in commit [382930f] dated 16 Dec 2002.
Attached patch fix the problem.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by cosoleto (cosoleto@….com) on Feb 9, 2010 at 18:32 UTC

@mc-butler
Copy link
Author

Changed by cosoleto (cosoleto@….com) on Feb 9, 2010 at 18:32 UTC

@mc-butler
Copy link
Author

Changed by cosoleto (cosoleto@….com) on Feb 9, 2010 at 18:49 UTC (comment 1)

  • Summary changed from Don't try to make directory NULL named in mkdir_cmd() to [PATCH] Don't try to make directory NULL named in mkdir_cmd()

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 9, 2010 at 19:03 UTC (comment 2)

  • Description edited
  • Version changed from version not selected to master

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 17, 2010 at 9:12 UTC (comment 3)

  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.7.2
  • Votes set to andrew_b
  • Owner set to andrew_b
  • Severity changed from no branch to on review

Created 2014_null_directory branch. Parent branch is master.
[b4e13ce52e36beaff0f55b8db7943159c8c112a1]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 17, 2010 at 10:22 UTC (comment 4)

  • Severity changed from on review to approved
  • Votes changed from andrew_b to andrew_b slavazanko

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 17, 2010 at 10:32 UTC (comment 5)

  • Votes changed from andrew_b slavazanko to commited-master
  • Resolution set to fixed
  • Status changed from accepted to testing
  • Severity changed from approved to merged

Merged to master.
[36771dc]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 17, 2010 at 10:38 UTC (comment 6)

  • Votes changed from commited-master to commited-master commited-stable
  • Status changed from testing to closed

Cherry-picked to 4.7.0-stable.
[c8ade19]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.7.2
Development

No branches or pull requests
2 participants
@aborodin @mc-butler