Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in mc_symlink() function #2053

Closed
mc-butler opened this issue Feb 22, 2010 · 7 comments
Closed

Memory leak in mc_symlink() function #2053

mc-butler opened this issue Feb 22, 2010 · 7 comments
Assignees
@aborodin
Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.1

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2053
Reporter vit_r (vit_r@….ru)

when a try to bring this old fashion style 

    mpath = ...
    if (mpath != NULL) {
    vfs = vfs_get_class (mpath);
    result = vfs->setctl ? (...) : 0;
    g_free (mpath);
    return result;
    } else return -1;

to currently (for mc) looking like

    mpath = ...
    if (mpath == NULL)
	return -1;
	
    vfs = vfs_get_class (mpath);
    result = vfs->setctl ? (...) : 0;
    g_free (mpath);
    return result;

this missing g_free() popped up



Note

Original attachments:
@mc-butler
Copy link
Author

Changed by vit_r (vit_r@….ru) on Feb 22, 2010 at 17:31 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 23, 2010 at 9:17 UTC (comment 1)

  • Milestone changed from 4.7 to 4.7.1
  • Severity changed from no branch to on review
  • Priority changed from trivial to major
  • Description edited
  • Status changed from new to accepted
  • Owner set to andrew_b

Created 2053_vfs_memleak branch. Parent branch is master.
[37aee9a69aaf19bce9296f5cbe8e3dc93d815a9f]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Feb 23, 2010 at 9:46 UTC (comment 2)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 24, 2010 at 8:44 UTC (comment 3)

  • Summary changed from lib-vfs-mc-vfs-vfs.c-mc_symlink-missing-g_free to Memory leak in mc_symlink() function

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Feb 24, 2010 at 8:51 UTC (comment 4)

  • Severity changed from on review to approved
  • Votes changed from slavazanko to slavazanko angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 24, 2010 at 9:02 UTC (comment 5)

  • Severity changed from approved to merged
  • Votes changed from slavazanko angel_il to commited-master commited-stable
  • Resolution set to fixed
  • Status changed from accepted to testing

Merged to master.
[3770047]

Cherry-picked to 4.7.0-stable.
[03a4c35]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 24, 2010 at 9:02 UTC (comment 6)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: vfs Virtual File System support prio: medium Has the potential to affect progress
Milestone
4.7.1
Development

No branches or pull requests
2 participants
@aborodin @mc-butler