Ticket #2323 (accepted defect)

Opened 15 years ago

Last modified 9 months ago

Syntax hightlighting rule order bogus

Reported by: ossi Owned by: zaytsev
Priority: major Milestone: 4.8.34
Component: mcedit Version: master
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

opening the file makefile.cpp in the editor causes it to be highlighted with Makefile syntax instead of C++ syntax.

the fix is checking the extension rules first.

Attachments

0001-match-makefile-syntax-towards-the-end.patch​ (1.1 KB) - added by ossi 5 years ago.

Change History

comment:1 Changed 15 years ago by ossi

also, the regexp is waaaaay too broad. it should be something like that:

file ([Mm]akefile(\\...\*)?|..\*\\.mk|Kbuild)$ Makefile
Last edited 12 years ago by ossi (previous) (diff)

comment:2 Changed 15 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Cc zaytsev added

comment:3 Changed 15 years ago by andrew_b

  • Blocked By 2308 added

comment:4 Changed 14 years ago by andrew_b

  • Branch state set to no branch
  • Milestone set to Future Releases

Changed 5 years ago by ossi

comment:5 Changed 9 months ago by trac

  • Blocked By 2308 removed

(In #2308) Ticket #2308 deleted

comment:6 Changed 9 months ago by zaytsev

  • Milestone changed from Future Releases to 4.8.34
  • Summary changed from syntax hightlighting rule order bogus to Syntax hightlighting rule order bogus

TODO:

  1. Sort.
  1. Fix wrong patterns: 
file .\*\\.toml$ TOML\sFile
include toml.syntax

file .\*\\.(mch|ref|imp)$ B\sFile
include b.syntax
  1. ..\* -> .\+
  1. Patch by ossi.
Note: See TracTickets for help on using tickets.