Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended keybingings are broken #2586

Closed
mc-butler opened this issue Aug 2, 2011 · 6 comments
Closed

Extended keybingings are broken #2586

mc-butler opened this issue Aug 2, 2011 · 6 comments
Assignees
@aborodin
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress ver: 4.8.0-pre1 Reproducible in version 4.8.0-pre1
Milestone
4.8.0-pre2

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2586
Reporter andrew_b (@aborodin)

There are two bugs with extended keybingings in mcedit.

  1. ctrl-x in default keymap is used twice:
    1. as shotrcut for WordRight action (see MCEDIT ignores old (and documented) keys like CTRL+Z and CTRL+X #2404)
    2. as shortcut for extended keybindings mode. Because of MCEDIT ignores old (and documented) keys like CTRL+Z and CTRL+X #2404, we should change shortcut for editor.ExtendedKeyMap action.
  2. Extended shortcuts like ctrl-x ctrl-x or ctrl-x alt-x are available but extended shortcuts like ctrl-x x are not.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 2, 2011 at 9:08 UTC (comment 1)

  • Description edited

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 2, 2011 at 10:38 UTC (comment 2)

  • Keywords set to stable-candidate
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Status changed from new to accepted

Branch: 2586_mcedit_extended_keybindings (parent: master).
Initial [b0583850c6f58de22ea89e045c7ea24df11fc4e2]

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Aug 15, 2011 at 13:05 UTC (comment 3)

  • Votes set to slavazanko

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 24, 2011 at 6:58 UTC (comment 4)

  • Votes changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 26, 2011 at 6:32 UTC (comment 5)

  • Votes changed from slavazanko angel_il to committed-master
  • Branch state changed from approved to merged
  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master.
[eb13abc]

git log --pretty=oneline c4af1f2..eb13abc

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 8, 2011 at 10:51 UTC (comment 6)

  • Status changed from testing to closed
  • Votes changed from committed-master to committed-master committed-stable
  • Keywords stable-candidate deleted

Cherry-picked to 4.7.5-stable.
Initial [5f0cef1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress ver: 4.8.0-pre1 Reproducible in version 4.8.0-pre1
Milestone
4.8.0-pre2
Development

No branches or pull requests
2 participants
@aborodin @mc-butler