Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Hint" line jumps to the top of the screen and overwrites main menu #2593

Closed
mc-butler opened this issue Aug 15, 2011 · 8 comments
Closed

"Hint" line jumps to the top of the screen and overwrites main menu #2593

mc-butler opened this issue Aug 15, 2011 · 8 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.0-pre1 Reproducible in version 4.8.0-pre1
Milestone
4.8.0-pre2

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2593
Reporter sergem

Problem

"Hint" line jumps to the top of the screen and overwrites main menu

Steps to reproduce

  1. Run mc. See the "Hint" line near the command line as usual. Put the cursor on any file or folder.
  2. Press F8, see a confirmation box.
  3. Press Esc (two times) to avoid file deletion.
  4. That's all. The "Hint" line's jumped up. If it's not - goto 1.

I reproduced it 5 times with no more than 3 tries.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 16, 2011 at 7:18 UTC (comment 1)

  • Description edited
  • Summary changed from "Hint" line jumps to the top of the window and overwrite title to "Hint" line jumps to the top of the screen and overwrites main menu

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 16, 2011 at 9:11 UTC (comment 2)

An attached patch fixes the bug. But extra test is required to avoid potential regression in file operations.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 17, 2011 at 6:09 UTC (comment 2.3)

Patch was removed because it produced segfault. Sorry...

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 17, 2011 at 7:01 UTC (comment 4)

  • Owner set to andrew_b
  • Keywords changed from hint to stable-candidate
  • Milestone changed from Future Releases to 4.8.0-pre2
  • Status changed from new to accepted
  • Branch state changed from no branch to on review

Branch: 2593_hintbar (parent: master).
Initial [bfa147d745c93cfe76282d331a38691a02288dad]

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Aug 18, 2011 at 6:04 UTC (comment 5)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Aug 28, 2011 at 10:35 UTC (comment 6)

  • Branch state changed from on review to approved
  • Keywords changed from stable-candidate to hintbar, stable-candidate
  • Votes changed from angel_il to angel_il slavazanko

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 28, 2011 at 13:37 UTC (comment 7)

  • Votes changed from angel_il slavazanko to committed-master
  • Resolution set to fixed
  • Keywords changed from hintbar, stable-candidate to stable-candidate
  • Status changed from accepted to testing
  • Branch state changed from approved to merged

Merged to master.
[bf3dafb]

git log --pretty=oneline eb13abc..bf3dafb

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 8, 2011 at 10:54 UTC (comment 8)

  • Status changed from testing to closed
  • Votes changed from committed-master to committed-master committed-stable
  • Keywords stable-candidate deleted

Cherry-picked to stable.
Initial [d434ea4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.0-pre1 Reproducible in version 4.8.0-pre1
Milestone
4.8.0-pre2
Development

No branches or pull requests
2 participants
@aborodin @mc-butler