Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotlist: broken newly added entries if old-style path is present #2753

Closed
mc-butler opened this issue Mar 20, 2012 · 9 comments
Closed

hotlist: broken newly added entries if old-style path is present #2753

mc-butler opened this issue Mar 20, 2012 · 9 comments
Assignees
@slavaz
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.2 Reproducible in version 4.8.2
Milestone
4.8.3

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/2753
Reporter slavazanko (@slavaz)

Steps to reproduce:

  • try to replace your ~/.config/mc/hotlist by: 
    ENTRY "old-style-url" URL "/#sh:root@myserver.ru:C/var/www/site.ru/htdocs"
  • run mc, press ctrl+\ (call hotlist)
  • add current directory to hotlist
  • see content of your ~/.config/mc/hotlist

expected result: should be new entry with path to current directory

actual result: few random bytes here (looks like as data pointer)
@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 20, 2012 at 18:53 UTC (comment 1)

  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.3
  • Owner set to slavazanko

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 20, 2012 at 18:55 UTC (comment 2)

  • Description edited
  • Summary changed from hotlist: broken new entries if old-style path is present to hotlist: broken newly added entries if old-style path is present

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 21, 2012 at 13:36 UTC (comment 3)

  • Branch state changed from no branch to on review

Created branch 2753_broken_hotlist [fbff434f54be220caa8f19463c8fdfe83eae27e5]

Review, please.

@mc-butler
Copy link
Author

Changed by angel_il (@ilia-maslakov) on Mar 21, 2012 at 14:17 UTC (comment 4)

  • Votes set to angel_il

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Mar 22, 2012 at 6:36 UTC (comment 5)

  • Version changed from master to 4.8.2
  • Votes changed from angel_il to angel_il andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 22, 2012 at 8:19 UTC (comment 6)

  • Blocked by set to #2695
  • Votes changed from angel_il andrew_b to committed-master
  • Keywords set to stable-candidate
  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Status changed from accepted to testing

Merged to master:

git log --pretty=oneline 5b84f73..408ba2a

@mc-butler
Copy link
Author

Changed by NMorozov (nmorozoff77@….ru) on Mar 22, 2012 at 17:16 UTC (comment 7)

I have deleted hotlist and just created a new first entry (adding my home directory)
got this trash

hotlist

ENTRY "/home/nmorozov" URL ".wY.e/nmorozov"

As I understand all neww added entrys are broken

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Mar 22, 2012 at 17:24 UTC (comment 8)

Yes, all newly added entries have broken before fix. But current 'master' branch is free from this bug.

@mc-butler
Copy link
Author

Changed by slavazanko (@slavaz) on Apr 2, 2012 at 20:51 UTC (comment 9)

  • Keywords stable-candidate deleted
  • Blocked by #2695 deleted
  • Votes changed from committed-master to committed-master committed-stable
  • Status changed from testing to closed

Picked to stable as part of #2695

@mc-butler mc-butler marked this as a duplicate of #2770 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaz slavaz

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress ver: 4.8.2 Reproducible in version 4.8.2
Milestone
4.8.3
Development

No branches or pull requests
2 participants
@slavaz @mc-butler