Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] mcview hex: Incorrect highlight when search string not found #3263

Closed
mc-butler opened this issue Aug 31, 2014 · 6 comments
Closed

[patch] mcview hex: Incorrect highlight when search string not found #3263

mc-butler opened this issue Aug 31, 2014 · 6 comments
Assignees
@aborodin
Labels
area: mcview mcview, the built-in text editor prio: low Minor problem or easily worked around
Milestone
4.8.14

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3263
Reporter egmont (@egmontkob)

echo abcdefghijklmnopqrstuvwxyz > abc
mcview abc (at 80 columns)

Switch to hex mode.

Search for klm. The match is highlighted properly.

With the left arrow, walk back to let's say "e" (65).

Search for asdf. It's not found, yet efghijklm is highlighted as found text.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by and on Feb 16, 2015 at 17:44 UTC

restore prev string selection if search failed

@mc-butler
Copy link
Author

Changed by and on Feb 16, 2015 at 17:44 UTC (comment 1)

  • Summary changed from mcview hex: Incorrect highlight when search string not found to [patch] mcview hex: Incorrect highlight when search string not found

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 18, 2015 at 10:42 UTC (comment 2)

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Votes set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.14

Thanks! Applied.

Branch: 3263_hexview_highlight_found
[15cf75d]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 18, 2015 at 10:43 UTC (comment 3)

  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 18, 2015 at 10:44 UTC (comment 4)

  • Votes changed from andrew_b to committed-master
  • Status changed from accepted to testing
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [15cf75d].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 18, 2015 at 10:45 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: mcview mcview, the built-in text editor prio: low Minor problem or easily worked around
Milestone
4.8.14
Development

No branches or pull requests
2 participants
@aborodin @mc-butler