Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] introduce -Wundef check to catch macro typos #3430

Closed
mc-butler opened this issue Mar 29, 2015 · 8 comments
Closed

[patch] introduce -Wundef check to catch macro typos #3430

mc-butler opened this issue Mar 29, 2015 · 8 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.15

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3430
Reporter and

introduce -Wundef check to catch macro typos
more infos about motivation at https://sourceware.org/glibc/wiki/Wundef

patch 01/04: use always defined MC_HOMEDIR_XDG macro
patch 02/04: remove superfluous macro check
patch 03/04: use #ifdef for autoconf provided marcos
patch 04/04: use -Wundef compiler option for future compile checks

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by and on Mar 29, 2015 at 21:03 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 29, 2015 at 21:03 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 29, 2015 at 21:03 UTC

@mc-butler
Copy link
Author

Changed by and on Mar 29, 2015 at 21:03 UTC

@mc-butler
Copy link
Author

Changed by and on Apr 3, 2015 at 1:27 UTC

v2 of patch 02: respect macro logic

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Apr 5, 2015 at 6:59 UTC

  • Blocked by set to #3420

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 3, 2015 at 16:52 UTC

  • Blocked by #3420 deleted

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 3, 2015 at 17:00 UTC (comment 3)

  • Status changed from new to closed
  • Milestone changed from Future Releases to 4.8.15
  • Votes set to committed-master
  • Resolution set to fixed

Thanks!
Applied as [8a2f9e2], [d0d7d41], [57452f6], [850073c].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.15
Development

No branches or pull requests
1 participant
@mc-butler