Changed by and on Apr 3, 2015 at 1:31 UTC

• Attachment mc-cleanup-clang-warnings-01.patch (raw) added

Changed by and on Apr 3, 2015 at 1:31 UTC

• Attachment mc-cleanup-clang-warnings-03.patch (raw) added

Changed by and on Apr 3, 2015 at 1:31 UTC

• Attachment mc-cleanup-clang-warnings-04.patch (raw) added

Changed by and on Apr 3, 2015 at 1:31 UTC

• Attachment mc-cleanup-clang-warnings-05.patch (raw) added

Changed by and on Apr 3, 2015 at 1:32 UTC

• Attachment mc-cleanup-clang-warnings-06.patch (raw) added

Changed by and on Apr 3, 2015 at 1:32 UTC

• Attachment mc-cleanup-clang-warnings-07.patch (raw) added

Changed by andrew_b (@aborodin) on Apr 5, 2015 at 6:59 UTC

mc-cleanup-clang-warnings-01.patch​ looks not quite correct, because fcntl.h is included unconditionally everywhere it included in mc source tree. The another fix should be found.

mc-cleanup-clang-warnings-02.patch: if code is unused it should be removed not just commented out. Please don't use the //-style comments.

mc-cleanup-clang-warnings-06.patch and mc-cleanup-clang-warnings-07.patch will not be applied because we don't want support the ancient Samba code (see #1).

Changed by and on Apr 5, 2015 at 11:53 UTC (comment 2)

mc-cleanup-clang-warnings-01.patch
lib/global.h use defines depends on fcntl.h (if file exists)
lib/global.h will only initial once (MC_GLOBAL_H)
when global.h called first time on .c file _without_ previous pull of fcntl.h definitions
it is semi unpredictable which .c file (which called first time global.h) have a pulled fcntl.h definition.

currently lib/event/event.c is called first (compile session) and without proper fcntl.h definition.
so for me fcntl.h belongs inside of global.h

mc-cleanup-clang-warnings-02.patch
You are right, I will provide a new patch

mc-cleanup-clang-warnings-06.patch
mc-cleanup-clang-warnings-07.patch
Good to know, I will skip/delete theses patches

Changed by and on Apr 5, 2015 at 12:03 UTC

• Attachment mc-cleanup-clang-warnings-02.patch (raw) added

v2

Changed by andrew_b (@aborodin) on Apr 5, 2015 at 13:10 UTC (comment 2.3)

Replying to and:

mc-cleanup-clang-warnings-01.patch
lib/global.h use defines depends on fcntl.h (if file exists)
lib/global.h will only initial once (MC_GLOBAL_H)
when global.h called first time on .c file _without_ previous pull of fcntl.h definitions
it is semi unpredictable which .c file (which called first time global.h) have a pulled fcntl.h definition.

currently lib/event/event.c is called first (compile session) and without proper fcntl.h definition.
so for me fcntl.h belongs inside of global.h

Ok. Probably, include fcntl.h in global.h and remove all other includes of fcntl.h?

Changed by andrew_b (@aborodin) on Apr 5, 2015 at 13:18 UTC

• Attachment mc_fcntl.h.diff (raw) added

Include <fcntl.h> via "lib/global.h".

Changed by andrew_b (@aborodin) on Apr 11, 2015 at 10:10 UTC

• Blocked by set to #3420

Changed by andrew_b (@aborodin) on May 3, 2015 at 16:52 UTC

• Blocked by #3420 deleted

Changed by andrew_b (@aborodin) on May 3, 2015 at 17:03 UTC (comment 6)

• Resolution set to fixed
• Status changed from new to closed
• Votes set to committed-master
• Milestone changed from Future Releases to 4.8.15

Thanks!
Applied as [b698b7e], [bd051e4], [e9e6868], [d74be13], [0364995], [c9b0731]