Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find file results dialog title patch #3453

Closed
mc-butler opened this issue Apr 19, 2015 · 12 comments
Closed

Find file results dialog title patch #3453

mc-butler opened this issue Apr 19, 2015 · 12 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.22

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3453
Reporter Miven (mdooligan@….com)
Keywords find, file, results, dialog

Find File (M-?) works great. However, I often have more than 1 mc running on side by side workspaces grepping in the same huge directory for related things. When I get results from 2 side by side searches, there is no indication in the results dialog what the results were for. Sometimes these searches take quite a while and I cannot recall which one was for what by the time they complete.

I have a patch here that adds the Find pattern and Contents pattern (if used) to the results dialog title, so that you can see exactly what you were grepping for, after a lengthy search is completed.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by Miven (mdooligan@….com) on Apr 19, 2015 at 14:34 UTC

Find file search results dialog patch

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Mar 14, 2016 at 6:38 UTC (comment 1)

  • Milestone changed from Future Releases to 4.8.17
  • Status changed from new to accepted
  • Owner set to zaytsev

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Apr 30, 2016 at 21:02 UTC (comment 2)

  • Milestone changed from 4.8.17 to 4.8.18

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Sep 22, 2016 at 18:46 UTC (comment 3)

  • Milestone changed from 4.8.18 to 4.8.19

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Nov 18, 2017 at 17:31 UTC (comment 4)

  • Milestone changed from 4.8.20 to 4.8.21

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on May 27, 2018 at 13:14 UTC (comment 5)

  • Milestone changed from 4.8.21 to 4.8.22

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 29, 2018 at 10:31 UTC (comment 6)

  • Branch state changed from no branch to on review
  • Owner changed from zaytsev to andrew_b
  • Component changed from mc-search to mc-core

Branch: 3453_find_results_title
[67c6496031c23367e4db8caa4e3677058cdb01fc]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 3, 2018 at 6:24 UTC (comment 7)

  • Branch state changed from on review to on rework

Rework is required to support dialog resize.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 4, 2018 at 7:39 UTC (comment 7.8)

  • Branch state changed from on rework to on review

Replying to andrew_b:

Rework is required to support dialog resize.

Done.

Branch: 3453_find_results_title
Initial [a38c7f1]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 9, 2018 at 15:41 UTC (comment 9)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 9, 2018 at 15:43 UTC (comment 10)

  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master

Merged to master: [202b80a].

git log --pretty=oneline faa893b..202b80a

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Sep 9, 2018 at 15:44 UTC (comment 11)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.22
Development

No branches or pull requests
2 participants
@aborodin @mc-butler