Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] cleanup -Wmissing-variable-declarations warnings #3465

Closed
mc-butler opened this issue May 10, 2015 · 5 comments
Closed

[patch] cleanup -Wmissing-variable-declarations warnings #3465

mc-butler opened this issue May 10, 2015 · 5 comments
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.15

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3465
Reporter and

fix -Wmissing-variable-declarations warnings and add to mc cflags

color-internal.c:57:28: warning: no previous extern declaration for non-static variable 'color_table' [-Wmissing-variable-declarations]
color-internal.c:84:28: warning: no previous extern declaration for non-static variable 'attributes_table' [-Wmissing-variable-declarations]
vfs.c:65:12: warning: no previous extern declaration for non-static variable 'vfsclasses_list' [-Wmissing-variable-declarations]
vfs.c:67:10: warning: no previous extern declaration for non-static variable 'vfs_str_buffer' [-Wmissing-variable-declarations]
vfs.c:68:19: warning: no previous extern declaration for non-static variable 'current_vfs' [-Wmissing-variable-declarations]
interface.c:67:16: warning: no previous extern declaration for non-static variable 'mc_readdir_result' [-Wmissing-variable-declarations]
boxes.c:96:15: warning: no previous extern declaration for non-static variable 'configure_old_esc_mode_id' [-Wmissing-variable-declarations]
boxes.c:96:42: warning: no previous extern declaration for non-static variable 'configure_time_out_id' [-Wmissing-variable-declarations]
boxes.c:114:12: warning: no previous extern declaration for non-static variable 'skin_names' [-Wmissing-variable-declarations]
boxes.c:115:8: warning: no previous extern declaration for non-static variable 'current_skin_name' [-Wmissing-variable-declarations]
filegui.c:253:3: warning: no previous extern declaration for non-static variable 'progress_buttons' [-Wmissing-variable-declarations]
find.c:195:14: warning: no previous extern declaration for non-static variable 'quit_button' [-Wmissing-variable-declarations]
layout.c:105:5: warning: no previous extern declaration for non-static variable 'ok_to_refresh' [-Wmissing-variable-declarations]
extfs.c:69:9: warning: no previous extern declaration for non-static variable 'extfs_plugins' [-Wmissing-variable-declarations]
args.c:50:10: warning: no previous extern declaration for non-static variable 'mc_argsshow_version' [-Wmissing-variable-declarations]
args.c:195:15: warning: no previous extern declaration for non-static variable 'terminal_group' [-Wmissing-variable-declarations]
args.c:282:15: warning: no previous extern declaration for non-static variable 'color_group' [-Wmissing-variable-declarations]
setup.c:127:5: warning: no previous extern declaration for non-static variable 'saving_setup' [-Wmissing-variable-declarations]

Signed-off-by: Andreas Mohr <​and@gmx.li>

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by and on May 10, 2015 at 10:19 UTC

@mc-butler
Copy link
Author

Changed by and on May 10, 2015 at 14:53 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 10, 2015 at 15:18 UTC

  • Blocked by set to #3420

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 24, 2015 at 15:22 UTC (comment 2)

  • Status changed from new to closed
  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Milestone changed from Future Releases to 4.8.15

Thanks!
Applied as [f1b73ff].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on May 24, 2015 at 15:26 UTC

  • Blocked by #3420 deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around
Milestone
4.8.15
Development

No branches or pull requests
1 participant
@mc-butler