Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files of "unsorted" list shuffled #3496

Closed
mc-butler opened this issue Jul 5, 2015 · 8 comments
Closed

Files of "unsorted" list shuffled #3496

mc-butler opened this issue Jul 5, 2015 · 8 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.15

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3496
Reporter Nicolas Rybkin (mfkorenev@….ru)

I've found that qsort() may shuffle first and last files in some lists when sort_order is "unsorted". The solution is not to call qsort() for this sort_order.
*This is realy important issue* Sometimes user needs to know natural order of files in the list.

Note

Original attachments:

  • dir.c (raw) by Nicolas Rybkin (mfkorenev@….ru) on Jul 5, 2015 at 18:38 UTC
  • dir.c.diff (raw) by Nicolas Rybkin (mfkorenev@….ru) on Jul 5, 2015 at 18:38 UTC
@mc-butler
Copy link
Author

Changed by Nicolas Rybkin (mfkorenev@….ru) on Jul 5, 2015 at 18:38 UTC

fixed dir.c

@mc-butler
Copy link
Author

Changed by Nicolas Rybkin (mfkorenev@….ru) on Jul 5, 2015 at 18:38 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 19, 2015 at 14:23 UTC (comment 1)

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.15
  • Owner set to andrew_b
  • Status changed from new to accepted

Banch: 3496_unsorted
[20df549aba2ee17cf34eb13c346f2788d597e716]

@mc-butler
Copy link
Author

Changed by mooffie (@mooffie) on Oct 13, 2015 at 20:43 UTC (comment 2)

For reference, here's the mailing-list thread:

https://mail.gnome.org/archives/mc-devel/2015-June/msg00038.html

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 18, 2015 at 5:17 UTC (comment 3)

  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 18, 2015 at 5:18 UTC (comment 4)

  • Branch state changed from approved to merged
  • Resolution set to fixed
  • Votes changed from andrew_b to committed-master
  • Status changed from accepted to testing

Merged to master: [348eb94075f95c551b16cc905998c87c6c05b7ba].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 18, 2015 at 5:19 UTC (comment 5)

  • Status changed from testing to closed

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 18, 2015 at 16:25 UTC (comment 6)

New merge head: [7f29e0a].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: medium Has the potential to affect progress
Milestone
4.8.15
Development

No branches or pull requests
2 participants
@aborodin @mc-butler