Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcedit doesn't save all opened files #3898

Closed
mc-butler opened this issue Feb 10, 2018 · 4 comments
Closed

mcedit doesn't save all opened files #3898

mc-butler opened this issue Feb 10, 2018 · 4 comments
Assignees
@aborodin
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.8.21

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3898
Reporter andrew_b (@aborodin)

How to reproduce:

  1. Open several (two at least) files in the same editor.
  2. Modify some of them (two at least).
  3. Press F10 to quit editor.
  4. The message window "File xxx was modified. Save before close?" raises.

5a. Press "No" or "Yes".
Result: mcedit closes w/o ask to save other modified files. All changes in other files are lost.

Expected result: ask to save each modified file.
@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 10, 2018 at 15:29 UTC (comment 1)

  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.21
  • Status changed from new to accepted
  • Summary changed from mcedit doesnt save all opened files to mcedit doesn't save all opened files
  • Owner set to andrew_b

Branch: 3898_mcedit_save_files.
[db6538a7257e2ae32d1f3a04e2a4600a6c60c334]

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Feb 11, 2018 at 14:44 UTC (comment 2)

  • Votes set to zaytsev
  • Branch state changed from on review to approved

LGTM! Nit: Ticket # 3898 -> Ticket #3898.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 12, 2018 at 18:13 UTC (comment 3)

  • Votes changed from zaytsev to committed-master
  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Resolution set to fixed

Merged to master: [e41af67].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Feb 12, 2018 at 18:14 UTC (comment 4)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.8.21
Development

No branches or pull requests
2 participants
@aborodin @mc-butler