Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files .docx/.xlsx/.pptx created/edited in LibreOffice are not detected as MS Office files #3929

Closed
mc-butler opened this issue Aug 14, 2018 · 7 comments
Closed

Files .docx/.xlsx/.pptx created/edited in LibreOffice are not detected as MS Office files #3929

mc-butler opened this issue Aug 14, 2018 · 7 comments
Assignees
@aborodin
Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.8.19 Reproducible in version 4.8.19
Milestone
4.8.22

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3929
Reporter anatoly.borodin (anatoly.borodin@….com)

Files saved in the "2007-2013 XML" format by LibreOffice have different file type reported by file (file 1:5.32-2ubuntu0.1, Ubuntu 18.04 Bionic Beaver) and are therefore not detected as MS Office documents by mc.ext:

test.docx: Microsoft OOXML
test.pptx: Microsoft OOXML
test.xlsx: Zip archive data, at least v2.0 to extract

(I will file a separate bug at Launchpad or Debian regarding the xlsx file)

For a file created by the real MS Office I get

ms-office.docx: Microsoft Word 2007+

There are two possibilities to fix it:

  1. Add something like this to mc.ext.in 
type/^Microsoft\ OOXML
        Open=@EXTHELPERSDIR@/doc.sh open ooffice
  1. Detect the files by regex/i.

Which fix is better?

Note

Original attachments:

  • test.docx (raw) by anatoly.borodin (anatoly.borodin@….com) on Aug 14, 2018 at 5:26 UTC
  • test.pptx (raw) by anatoly.borodin (anatoly.borodin@….com) on Aug 14, 2018 at 5:26 UTC
  • test.xlsx (raw) by anatoly.borodin (anatoly.borodin@….com) on Aug 14, 2018 at 5:26 UTC
@mc-butler
Copy link
Author

Changed by anatoly.borodin (anatoly.borodin@….com) on Aug 14, 2018 at 5:26 UTC

@mc-butler
Copy link
Author

Changed by anatoly.borodin (anatoly.borodin@….com) on Aug 14, 2018 at 5:26 UTC

@mc-butler
Copy link
Author

Changed by anatoly.borodin (anatoly.borodin@….com) on Aug 14, 2018 at 5:26 UTC

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 19, 2018 at 14:19 UTC (comment 1)

  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.22
  • Status changed from new to accepted

Branch: 3929_office_formats_ext
Initial [feab399]

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 28, 2018 at 7:43 UTC (comment 2)

  • Branch state changed from on review to approved
  • Votes set to andrew_b

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 28, 2018 at 7:45 UTC (comment 3)

  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Votes changed from andrew_b to committed-master
  • Resolution set to fixed

Merged to master: [5f80acd].

git log ==pretty=oneline 4059d3a..5f80acd

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 28, 2018 at 7:47 UTC (comment 4)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: core Issues not related to a specific subsystem prio: low Minor problem or easily worked around ver: 4.8.19 Reproducible in version 4.8.19
Milestone
4.8.22
Development

No branches or pull requests
2 participants
@aborodin @mc-butler