Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add inlined data block highlighting for YAML syntax highlighting #4010

Closed
mc-butler opened this issue Aug 26, 2019 · 6 comments
Closed

add inlined data block highlighting for YAML syntax highlighting #4010

mc-butler opened this issue Aug 26, 2019 · 6 comments
Assignees
@aborodin
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.8.24

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/4010
Reporter jetpilot (alexander.stohr@….com)

using certain character seqeunces YAML allows embedding texts and binary data of totally different nature (incluing e.g. HTML). the termination is the next valid block. (as the syntax highlighter of MC has a few limitations this highlighting as proposed below might miss some rare constructs or might select text that is not perfectly conforming with YAML rules. still its already lots better than the current state.)

i am proposing to add these lines to the end of the YAML syntax file:

context exclusive |\[123456789\+\-\s\t\]\n \n- brown
context exclusive >\[123456789\+\-\s\t\]\n \n- brown

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by jetpilot (alexander.stohr@….com) on Aug 27, 2019 at 7:16 UTC (comment 1)

https://github.com/MidnightCommander/mc/blob/master/misc/syntax/yaml.syntax

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 27, 2019 at 7:57 UTC (comment 2)

The best way is patch created using git format-patch.

@mc-butler
Copy link
Author

Changed by jetpilot (alexander.stohr@….com) on Aug 27, 2019 at 8:14 UTC

patch against current git state of the syntax file in question

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 31, 2019 at 16:32 UTC (comment 3)

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.24

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 31, 2019 at 16:34 UTC (comment 4)

  • Branch state changed from no branch to merged
  • Status changed from accepted to testing
  • Resolution set to fixed
  • Votes set to committed-master

Thanks!
Applied as [19cc61c].

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Aug 31, 2019 at 16:35 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborodin aborodin

Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress
Milestone
4.8.24
Development

No branches or pull requests
2 participants
@aborodin @mc-butler